Bug 140955

Summary: [WebAudio] AudioBufferSourceNodes should accurately play backwards if given a negative playbackRate.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eric.carlson, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 141263    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-mavericks
none
Archive of layout-test-results from ews107 for mac-mavericks-wk2
none
Patch
none
Patch for landing none

Jer Noble
Reported 2015-01-27 13:51:22 PST
[WebAudio] AudioBufferSourceNodes should accurately play backwards if given a negative playbackRate.
Attachments
Patch (689.66 KB, patch)
2015-01-28 10:17 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-mavericks (1.57 MB, application/zip)
2015-01-28 11:06 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (1.69 MB, application/zip)
2015-01-28 11:11 PST, Build Bot 		no flags
Details
Patch (693.08 KB, patch)
2015-01-28 15:54 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (26.97 KB, patch)
2015-02-06 22:00 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2015-01-28 10:17:31 PST
Created attachment 245551 [details] Patch
Build Bot
Comment 2 2015-01-28 11:06:14 PST
Comment on attachment 245551 [details] Patch Attachment 245551 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4723800142774272 New failing tests: webaudio/audiobuffersource-start.html webaudio/note-grain-on-play.html webaudio/audiobuffersource-negative-playbackrate.html webaudio/note-grain-on-timing.html webaudio/audiobuffersource-negative-playbackrate-interpolated.html
Build Bot
Comment 3 2015-01-28 11:06:17 PST
Created attachment 245554 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 4 2015-01-28 11:11:42 PST
Comment on attachment 245551 [details] Patch Attachment 245551 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5007196043608064 New failing tests: webaudio/audiobuffersource-start.html webaudio/note-grain-on-play.html webaudio/audiobuffersource-negative-playbackrate.html webaudio/note-grain-on-timing.html webaudio/audiobuffersource-negative-playbackrate-interpolated.html
Build Bot
Comment 5 2015-01-28 11:11:46 PST
Created attachment 245555 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Jer Noble
Comment 6 2015-01-28 15:54:26 PST
Created attachment 245574 [details] Patch
WebKit Commit Bot
Comment 7 2015-02-04 11:37:45 PST
Comment on attachment 245574 [details] Patch Clearing flags on attachment: 245574 Committed r179618: <http://trac.webkit.org/changeset/179618>
WebKit Commit Bot
Comment 8 2015-02-04 11:37:50 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 9 2015-02-04 14:38:42 PST
Re-opened since this is blocked by bug 141263
Jer Noble
Comment 10 2015-02-06 22:00:25 PST
Created attachment 246198 [details] Patch for landing
WebKit Commit Bot
Comment 11 2015-02-09 11:45:58 PST
Comment on attachment 246198 [details] Patch for landing Clearing flags on attachment: 246198 Committed r179838: <http://trac.webkit.org/changeset/179838>
WebKit Commit Bot
Comment 12 2015-02-09 11:46:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.