Bug 140944

Summary: Simple line layout: Move FlowContents iterator interface to FlowContentsIterator.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2015-01-27 11:04:08 PST
To cleanup FlowContents's interface.
Attachments
Patch (27.49 KB, patch)
2015-01-27 11:16 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (50.19 KB, patch)
2015-01-28 07:22 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (50.27 KB, patch)
2015-01-28 10:32 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (53.22 KB, patch)
2015-01-28 12:38 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2015-01-27 11:16:31 PST
Created attachment 245456 [details] Patch
Antti Koivisto
Comment 2 2015-01-27 11:26:46 PST
Comment on attachment 245456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245456&action=review > Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:86 > mutable LazyLineBreakIterator m_lineBreakIterator; Should this move down too? > Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:90 > +class FlowContentsIterator : public FlowContents { I'd prefer FlowContentsIterator to have FlowContents instead of being one.
Antti Koivisto
Comment 3 2015-01-27 11:27:29 PST
Comment on attachment 245456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245456&action=review >> Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:90 >> +class FlowContentsIterator : public FlowContents { > > I'd prefer FlowContentsIterator to have FlowContents instead of being one. You should split this to two files at some point.
alan
Comment 4 2015-01-28 07:22:53 PST
Created attachment 245540 [details] Patch
alan
Comment 5 2015-01-28 10:32:21 PST
Created attachment 245552 [details] Patch
alan
Comment 6 2015-01-28 12:38:38 PST
Created attachment 245565 [details] Patch
WebKit Commit Bot
Comment 7 2015-01-28 13:37:41 PST
Comment on attachment 245565 [details] Patch Clearing flags on attachment: 245565 Committed r179284: <http://trac.webkit.org/changeset/179284>
WebKit Commit Bot
Comment 8 2015-01-28 13:37:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.