Bug 140944

Summary: Simple line layout: Move FlowContents iterator interface to FlowContentsIterator.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2015-01-27 11:04:08 PST 
To cleanup FlowContents's interface.
Comment 1 zalan 2015-01-27 11:16:31 PST 
Created attachment 245456 [details]
Patch
Comment 2 Antti Koivisto 2015-01-27 11:26:46 PST 
Comment on attachment 245456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245456&action=review

> Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:86
>      mutable LazyLineBreakIterator m_lineBreakIterator;

Should this move down too?

> Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:90
> +class FlowContentsIterator : public FlowContents {

I'd prefer FlowContentsIterator to have FlowContents instead of being one.
Comment 3 Antti Koivisto 2015-01-27 11:27:29 PST 
Comment on attachment 245456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245456&action=review

>> Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:90
>> +class FlowContentsIterator : public FlowContents {
> 
> I'd prefer FlowContentsIterator to have FlowContents instead of being one.

You should split this to two files at some point.
Comment 4 zalan 2015-01-28 07:22:53 PST 
Created attachment 245540 [details]
Patch
Comment 5 zalan 2015-01-28 10:32:21 PST 
Created attachment 245552 [details]
Patch
Comment 6 zalan 2015-01-28 12:38:38 PST 
Created attachment 245565 [details]
Patch
Comment 7 WebKit Commit Bot 2015-01-28 13:37:41 PST 
Comment on attachment 245565 [details]
Patch

Clearing flags on attachment: 245565

Committed r179284: <http://trac.webkit.org/changeset/179284>
Comment 8 WebKit Commit Bot 2015-01-28 13:37:45 PST 
All reviewed patches have been landed.  Closing bug.