| Summary: | [MSE] Setting timestampOffset does not change the timestamps in the actual sample, leading to visual and audible errors. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, commit-queue, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jer Noble
2015-01-27 01:26:18 PST
Created attachment 245430 [details]
Patch
Comment on attachment 245430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245430&action=review > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:550 > + timingInfoArray.resize(itemCount); This should use grow rather than resize since we know itemCount is >= timingInfoArray.size(). Created attachment 245942 [details]
Patch for landing
Comment on attachment 245942 [details] Patch for landing Clearing flags on attachment: 245942 Committed r179564: <http://trac.webkit.org/changeset/179564> This broke http/tests/media/media-source/mediasource-config-change-mp4-v-framerate.html on some testers: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fmedia%2Fmedia-source%2Fmediasource-config-change-mp4-v-framerate.html Created attachment 245974 [details]
Follow-up patch to fix broken test
Comment on attachment 245974 [details] Follow-up patch to fix broken test Clearing flags on attachment: 245974 Committed r179577: <http://trac.webkit.org/changeset/179577> |