Bug 140911

Summary: Invoking an immediate action on link often dismisses selection
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Beth Dakin 2015-01-26 16:50:51 PST 
Invoking an immediate action on link often dismisses existing selection. It should not.

rdar://problem/19572685
Comment 1 Beth Dakin 2015-01-26 16:53:22 PST 
Created attachment 245391 [details]
Patch
Comment 2 Tim Horton 2015-01-26 20:16:55 PST 
Comment on attachment 245391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245391&action=review

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:-210
> -    _page->setMaintainsInactiveSelection(false);

I don't think we can get rid of this one, can we?
Comment 3 Beth Dakin 2015-01-27 11:14:44 PST 
(In reply to comment #2)
> Comment on attachment 245391 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245391&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:-210
> > -    _page->setMaintainsInactiveSelection(false);
> 
> I don't think we can get rid of this one, can we?

It actually seems like dismissContentRelativeChildWindows is typically called through WKView code on cancel, but it seems best not to rely on that, so I kept this one. There is certainly no downside.

http://trac.webkit.org/changeset/179195