Bug 140898

Summary: Web Inspector: DebuggerSidebarPanel: _addBreakpoint function has unnecessary parameter
Product: WebKit Reporter: Jonathan Wells <jonowells>
Component: Web InspectorAssignee: Jonathan Wells <jonowells>
Status: RESOLVED WONTFIX    
Severity: Normal CC: graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   

Description Jonathan Wells 2015-01-26 13:12:24 PST
Near line 310 of the DebuggerSidebarPanel.js file is this call:

    this._addBreakpoint(breakpoints[i], sourceCode);

However this function begins:

    _addBreakpoint: function(breakpoint, sourceCode)
    {
        var sourceCode = breakpoint.sourceCodeLocation.displaySourceCode;

Clearly this second parameter is unnecessary.
Comment 1 Radar WebKit Bug Importer 2015-01-26 13:12:53 PST
<rdar://problem/19603573>
Comment 2 Radar WebKit Bug Importer 2015-01-26 13:12:58 PST
<rdar://problem/19603574>
Comment 3 Matt Baker 2016-08-04 17:57:48 PDT
The function in question has changed since this was filed, and this is no longer an issue.