Bug 140862

Summary:

Long spins under Frame::rangeForPoint when doing Lookup on feedly.com

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+

Description Tim Horton 2015-01-25 00:09:34 PST

Long spins under Frame::rangeForPoint when doing Lookup on feedly.com

Comment 1 Tim Horton 2015-01-25 00:10:03 PST

Created attachment 245296 [details]
Patch

Comment 2 mitz 2015-01-25 00:12:59 PST

Comment on attachment 245296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245296&action=review

> Source/WebCore/page/Frame.cpp:856
> +    if (!containerText)
> +        return nullptr;
> +    if (!containerText->renderer() || containerText->renderer()->style().userSelect() == SELECT_NONE)

I’d combine these into one condition.

Comment 3 Tim Horton 2015-01-25 00:18:06 PST

http://trac.webkit.org/changeset/179086