Bug 140857

Summary:

[Win] Add WebKit message loop interface.

Product:

WebKit

Reporter:

peavo

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex.christensen, bfulgham, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

peavo

Reported 2015-01-24 08:23:35 PST

For applications embedding WebKit it's important that certain tasks are performed on each iteration of the message loop, like calling CFRunLoopRunInMode. This is not obvious, and easy to miss, so I think it would make sense to move this code into WebKit, and make it available through an interface.

Attachments
Patch (14.84 KB, patch) 2015-01-24 09:09 PST, peavo	no flags	Details Formatted Diff Diff
Patch (16.16 KB, patch) 2015-01-25 00:20 PST, peavo	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

peavo

Comment 1 2015-01-24 09:09:39 PST

Created attachment 245284 [details] Patch

WebKit Commit Bot

Comment 2 2015-01-24 09:11:37 PST

Attachment 245284 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebKitMessageLoop.cpp:1: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

David Kilzer (:ddkilzer)

Comment 3 2015-01-24 18:22:33 PST

Comment on attachment 245284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245284&action=review r- to fix WebKitMessageLoop.cpp as noted below. (I am not a good reviewer for this change, but these two things need to be fixed, and fixing them before the actual reviewer looks will speed things along.) > Source/WebKit/win/WebKitMessageLoop.cpp:1 > +#include "WebKitMessageLoop.h" Needs a license header and: #include "config.h" before #include "WebKitMessageLoop.h" (as noted by the stylebot).

Brent Fulgham

Comment 4 2015-01-24 22:10:33 PST

Comment on attachment 245284 [details] Patch In general, I think this patch is good. Please correct the (minor) style-bot complaint and I think we are ready to go!

peavo

Comment 5 2015-01-25 00:20:12 PST

Created attachment 245297 [details] Patch

peavo

Comment 6 2015-01-25 00:22:10 PST

Thanks for reviewing! Added license header, and fixed style issue.

Brent Fulgham

Comment 7 2015-01-25 09:17:20 PST

Comment on attachment 245297 [details] Patch Looks great!

WebKit Commit Bot

Comment 8 2015-01-25 10:01:10 PST

Comment on attachment 245297 [details] Patch Clearing flags on attachment: 245297 Committed r179088: <http://trac.webkit.org/changeset/179088>

WebKit Commit Bot

Comment 9 2015-01-25 10:01:13 PST

All reviewed patches have been landed. Closing bug.

peavo

Comment 10 2015-01-25 12:01:38 PST

(In reply to comment #7) > Comment on attachment 245297 [details] > Patch > > Looks great! Thanks for reviewing, Brent :)

Note You need to log in before you can comment on or make changes to this bug.