For applications embedding WebKit it's important that certain tasks are performed on each iteration of the message loop, like calling CFRunLoopRunInMode. This is not obvious, and easy to miss, so I think it would make sense to move this code into WebKit, and make it available through an interface.
Created attachment 245284 [details] Patch
Attachment 245284 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebKitMessageLoop.cpp:1: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 245284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245284&action=review r- to fix WebKitMessageLoop.cpp as noted below. (I am not a good reviewer for this change, but these two things need to be fixed, and fixing them before the actual reviewer looks will speed things along.) > Source/WebKit/win/WebKitMessageLoop.cpp:1 > +#include "WebKitMessageLoop.h" Needs a license header and: #include "config.h" before #include "WebKitMessageLoop.h" (as noted by the stylebot).
Comment on attachment 245284 [details] Patch In general, I think this patch is good. Please correct the (minor) style-bot complaint and I think we are ready to go!
Created attachment 245297 [details] Patch
Thanks for reviewing! Added license header, and fixed style issue.
Comment on attachment 245297 [details] Patch Looks great!
Comment on attachment 245297 [details] Patch Clearing flags on attachment: 245297 Committed r179088: <http://trac.webkit.org/changeset/179088>
All reviewed patches have been landed. Closing bug.
(In reply to comment #7) > Comment on attachment 245297 [details] > Patch > > Looks great! Thanks for reviewing, Brent :)