Bug 140857 - [Win] Add WebKit message loop interface.
Summary: [Win] Add WebKit message loop interface.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-24 08:23 PST by peavo
Modified: 2015-01-25 12:01 PST (History)
3 users (show)

See Also:


Attachments
Patch (14.84 KB, patch)
2015-01-24 09:09 PST, peavo
no flags Details | Formatted Diff | Diff
Patch (16.16 KB, patch)
2015-01-25 00:20 PST, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-01-24 08:23:35 PST
For applications embedding WebKit it's important that certain tasks are performed on each iteration of the message loop, like calling CFRunLoopRunInMode. This is not obvious, and easy to miss, so I think it would make sense to move this code into WebKit, and make it available through an interface.
Comment 1 peavo 2015-01-24 09:09:39 PST
Created attachment 245284 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-24 09:11:37 PST
Attachment 245284 [details] did not pass style-queue:


ERROR: Source/WebKit/win/WebKitMessageLoop.cpp:1:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Kilzer (:ddkilzer) 2015-01-24 18:22:33 PST
Comment on attachment 245284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245284&action=review

r- to fix WebKitMessageLoop.cpp as noted below.  (I am not a good reviewer for this change, but these two things need to be fixed, and fixing them before the actual reviewer looks will speed things along.)

> Source/WebKit/win/WebKitMessageLoop.cpp:1
> +#include "WebKitMessageLoop.h"

Needs a license header and:

#include "config.h"

before #include "WebKitMessageLoop.h" (as noted by the stylebot).
Comment 4 Brent Fulgham 2015-01-24 22:10:33 PST
Comment on attachment 245284 [details]
Patch

In general, I think this patch is good. Please correct the (minor) style-bot complaint and I think we are ready to go!
Comment 5 peavo 2015-01-25 00:20:12 PST
Created attachment 245297 [details]
Patch
Comment 6 peavo 2015-01-25 00:22:10 PST
Thanks for reviewing! Added license header, and fixed style issue.
Comment 7 Brent Fulgham 2015-01-25 09:17:20 PST
Comment on attachment 245297 [details]
Patch

Looks great!
Comment 8 WebKit Commit Bot 2015-01-25 10:01:10 PST
Comment on attachment 245297 [details]
Patch

Clearing flags on attachment: 245297

Committed r179088: <http://trac.webkit.org/changeset/179088>
Comment 9 WebKit Commit Bot 2015-01-25 10:01:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 peavo 2015-01-25 12:01:38 PST
(In reply to comment #7)
> Comment on attachment 245297 [details]
> Patch
> 
> Looks great!

Thanks for reviewing, Brent :)