Bug 140844

Summary: Implement cache size limit
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Antti Koivisto <koivisto>
Status: NEW ---    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Antti Koivisto 2015-01-23 15:56:47 PST
Don't grow without limits.
Comment 1 Antti Koivisto 2015-01-23 16:13:12 PST
Created attachment 245257 [details]
Patch
Comment 2 Andreas Kling 2015-01-23 17:24:00 PST
Comment on attachment 245257 [details]
Patch

r=me
Comment 3 Chris Dumez 2015-01-23 17:27:08 PST
Comment on attachment 245257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245257&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:448
> +    m_maximumSize = 90 << 20;

What is this? m_maximumSize is initialized twice in a row.
Comment 4 Andreas Kling 2015-01-23 17:30:49 PST
Comment on attachment 245257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245257&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:502
> +                unlink(path.data());

Don't we have a WebCore abstraction for this?