Bug 140826

Summary:

Move height/width implementation for use element from RenderSVGViewportContainer to SVGUseElement

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

SVG

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, rniwa, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

140602

Attachments:

Description	Flags
Patch	andersca: review+, buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Archive of layout-test-results from ews102 for mac-mavericks	none

Darin Adler

Reported 2015-01-23 09:33:38 PST

Move height/width implementation for use element from RenderSVGViewportContainer to SVGUseElement

Attachments
Patch (61.68 KB, patch) 2015-01-23 09:42 PST, Darin Adler	andersca: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (704.06 KB, application/zip) 2015-01-23 10:02 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-mavericks (526.07 KB, application/zip) 2015-01-23 10:30 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2015-01-23 09:42:00 PST

Created attachment 245232 [details] Patch

Build Bot

Comment 2 2015-01-23 10:02:31 PST

Comment on attachment 245232 [details] Patch Attachment 245232 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5273941429977088 New failing tests: imported/mozilla/svg/dynamic-use-remove-width.svg

Build Bot

Comment 3 2015-01-23 10:02:35 PST

Created attachment 245235 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 4 2015-01-23 10:30:11 PST

Comment on attachment 245232 [details] Patch Attachment 245232 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6384392339456000 New failing tests: imported/mozilla/svg/dynamic-use-remove-width.svg

Build Bot

Comment 5 2015-01-23 10:30:13 PST

Created attachment 245236 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Anders Carlsson

Comment 6 2015-01-23 10:41:27 PST

Comment on attachment 245232 [details] Patch Test failures seem unrelated, but I'm only going to r+, not cq+.

Darin Adler

Comment 7 2015-01-23 17:57:30 PST

I think the test failure is related. I will fix before landing.

Darin Adler

Comment 8 2015-01-24 11:56:10 PST

Committed r179069: <http://trac.webkit.org/changeset/179069>

Note You need to log in before you can comment on or make changes to this bug.