Bug 140825 – [Mac][EME] Support ClearKey encryption with AES128-encrypted HLS

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

[Mac][EME] Support ClearKey encryption with AES128-encrypted HLS

[Radar WebKit Bug Importer]

<rdar://problem/19578900>

[Jer Noble]

Created attachment 245233 [details]
Patch

[Eric Carlson]

Comment on attachment 245233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245233&action=review

> Source/WebCore/Modules/encryptedmedia/CDMSessionClearKey.cpp:128
> +            if (!keysArray.get(i, keyDictionary) || keyDictionary.isUndefinedOrNull())
> +                continue;

It is probably worth adding logging in these failure cases.

> Source/WebCore/Modules/encryptedmedia/CDMSessionClearKey.h:48
> +    virtual RefPtr<ArrayBuffer> cachedKeyForKeyID(const String&) override;

Can't this and all of the related methods in other classes be declared "const"?

[Jer Noble]

Created attachment 245243 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 245243 [details]
Patch for landing

Clearing flags on attachment: 245243

Committed r179051: <http://trac.webkit.org/changeset/179051>

[Tim Horton]

This broke the 32-bit Mac build.

[Jer Noble]

Created attachment 245286 [details]
Patch for landing - w/32-bit build fix

[WebKit Commit Bot]

Comment on attachment 245286 [details]
Patch for landing - w/32-bit build fix

Clearing flags on attachment: 245286

Committed r179641: <http://trac.webkit.org/changeset/179641>