Bug 140820

Summary: Hang CSSFontSelector off Document instead of StyleResolver.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+
Patch for landing none

Description Andreas Kling 2015-01-23 00:43:28 PST 
Move the CSSFontSelector from StyleResolver to Document. This is the first step
towards making the CSSFontSelector be able to survive full style recalculations.
Comment 1 Andreas Kling 2015-01-23 01:02:36 PST 
Created attachment 245216 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-23 01:05:29 PST 
Attachment 245216 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:45:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2015-01-23 09:30:52 PST 
Comment on attachment 245216 [details]
Patch

I suspect you could remove StyleResolver.h include from some of these places too.
Comment 4 Andreas Kling 2015-01-23 09:59:20 PST 
Created attachment 245234 [details]
Patch for landing
Comment 5 Andreas Kling 2015-01-23 10:44:33 PST 
Committed r179012: <http://trac.webkit.org/changeset/179012>