Bug 140820

Summary: Hang CSSFontSelector off Document instead of StyleResolver.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+
Patch for landing none

Andreas Kling
Reported 2015-01-23 00:43:28 PST
Move the CSSFontSelector from StyleResolver to Document. This is the first step towards making the CSSFontSelector be able to survive full style recalculations.
Attachments
Patch (22.49 KB, patch)
2015-01-23 01:02 PST, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Patch for landing (23.15 KB, patch)
2015-01-23 09:59 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-01-23 01:02:36 PST
Created attachment 245216 [details] Patch
WebKit Commit Bot
Comment 2 2015-01-23 01:05:29 PST
Attachment 245216 [details] did not pass style-queue: ERROR: Source/WebCore/dom/Document.cpp:45: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2015-01-23 09:30:52 PST
Comment on attachment 245216 [details] Patch I suspect you could remove StyleResolver.h include from some of these places too.
Andreas Kling
Comment 4 2015-01-23 09:59:20 PST
Created attachment 245234 [details] Patch for landing
Andreas Kling
Comment 5 2015-01-23 10:44:33 PST
Committed r179012: <http://trac.webkit.org/changeset/179012>
Note You need to log in before you can comment on or make changes to this bug.