Bug 140817

Summary: Demote 'line-height' to a low priority property.
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, kling, koivisto
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: https://src.chromium.org/viewvc/blink?view=rev&revision=184629
Bug Depends on: 140577    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2015-01-22 23:12:17 PST 
Demote 'line-height' to a low priority property.

Our special handling of the 'line-height' property will no longer be required once the 'font' shorthand is expanded in the parser in all cases (also for system fonts).
Comment 1 Chris Dumez 2015-01-25 18:01:30 PST 
Related WebKit commit:
https://bugs.webkit.org/show_bug.cgi?id=13174
Comment 2 Chris Dumez 2015-01-25 23:19:11 PST 
Created attachment 245330 [details]
Patch
Comment 3 Andreas Kling 2015-01-26 09:07:05 PST 
Comment on attachment 245330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245330&action=review

r=me

> Source/WebCore/css/StyleResolver.cpp:-2691
> -    // FIXME: It would be nice if line-height were less of a special snowflake.

I'm so happy to see this comment finally go away :)
Comment 4 WebKit Commit Bot 2015-01-26 09:52:37 PST 
Comment on attachment 245330 [details]
Patch

Clearing flags on attachment: 245330

Committed r179119: <http://trac.webkit.org/changeset/179119>
Comment 5 WebKit Commit Bot 2015-01-26 09:52:42 PST 
All reviewed patches have been landed.  Closing bug.