WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140817
Demote 'line-height' to a low priority property.
https://bugs.webkit.org/show_bug.cgi?id=140817
Summary
Demote 'line-height' to a low priority property.
Chris Dumez
Reported
2015-01-22 23:12:17 PST
Demote 'line-height' to a low priority property. Our special handling of the 'line-height' property will no longer be required once the 'font' shorthand is expanded in the parser in all cases (also for system fonts).
Attachments
Patch
(11.36 KB, patch)
2015-01-25 23:19 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2015-01-25 18:01:30 PST
Related WebKit commit:
https://bugs.webkit.org/show_bug.cgi?id=13174
Chris Dumez
Comment 2
2015-01-25 23:19:11 PST
Created
attachment 245330
[details]
Patch
Andreas Kling
Comment 3
2015-01-26 09:07:05 PST
Comment on
attachment 245330
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=245330&action=review
r=me
> Source/WebCore/css/StyleResolver.cpp:-2691 > - // FIXME: It would be nice if line-height were less of a special snowflake.
I'm so happy to see this comment finally go away :)
WebKit Commit Bot
Comment 4
2015-01-26 09:52:37 PST
Comment on
attachment 245330
[details]
Patch Clearing flags on attachment: 245330 Committed
r179119
: <
http://trac.webkit.org/changeset/179119
>
WebKit Commit Bot
Comment 5
2015-01-26 09:52:42 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug