Bug 140817 - Demote 'line-height' to a low priority property.
Summary: Demote 'line-height' to a low priority property.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://src.chromium.org/viewvc/blink...
Keywords: BlinkMergeCandidate
Depends on: 140577
Blocks:
  Show dependency tree / graph
 
Reported: 2015-01-22 23:12 PST by Chris Dumez
Modified: 2015-01-26 09:52 PST (History)
4 users (show)

See Also:

Attachments
Patch (11.36 KB, patch)
2015-01-25 23:19 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-22 23:12:17 PST 
Demote 'line-height' to a low priority property.

Our special handling of the 'line-height' property will no longer be required once the 'font' shorthand is expanded in the parser in all cases (also for system fonts).
Comment 1 Chris Dumez 2015-01-25 18:01:30 PST 
Related WebKit commit:
https://bugs.webkit.org/show_bug.cgi?id=13174
Comment 2 Chris Dumez 2015-01-25 23:19:11 PST 
Created attachment 245330 [details]
Patch
Comment 3 Andreas Kling 2015-01-26 09:07:05 PST 
Comment on attachment 245330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245330&action=review

r=me

> Source/WebCore/css/StyleResolver.cpp:-2691
> -    // FIXME: It would be nice if line-height were less of a special snowflake.

I'm so happy to see this comment finally go away :)
Comment 4 WebKit Commit Bot 2015-01-26 09:52:37 PST 
Comment on attachment 245330 [details]
Patch

Clearing flags on attachment: 245330

Committed r179119: <http://trac.webkit.org/changeset/179119>
Comment 5 WebKit Commit Bot 2015-01-26 09:52:42 PST 
All reviewed patches have been landed.  Closing bug.