Bug 140800

Summary: [GTK] Scrollbars look bad with GTK+ 3.16
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, mcatanzaro, pnormand, svillar, yoseforb
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Screenshot: upstream scrollbars are half this wide and only appear on mouseover
none
Patch svillar: review+

Michael Catanzaro
Reported 2015-01-22 16:29:34 PST
Created attachment 245181 [details] Screenshot: upstream scrollbars are half this wide and only appear on mouseover GTK+ has started using overlay scrollbars (at least with the default Adwaita theme). Our scrollbars look out of place, and are too wide.
Attachments
Screenshot: upstream scrollbars are half this wide and only appear on mouseover (149.29 KB, image/png)
2015-01-22 16:29 PST, Michael Catanzaro 		no flags
Details
Patch (3.39 KB, patch)
2015-03-19 02:41 PDT, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-03-04 07:08:03 PST
I think the cross-platform code already supports overlay scrollbars. Does not look simple to hook up, though.
Carlos Garcia Campos
Comment 2 2015-03-04 07:14:42 PST
Even if we don't use the overlay scrollbars, the scrollbars should look good, something has changed in adwaita once again that broke our theming code.
Carlos Garcia Campos
Comment 3 2015-03-19 02:41:07 PDT
Created attachment 249028 [details] Patch
Sergio Villar Senin
Comment 4 2015-03-19 03:03:12 PDT
Comment on attachment 249028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249028&action=review r+ with a nit I guess we haven't detected it in the bots because they don't have 3.16. It's unfortunate to have to depend on dogfeeding to detect this kind of regressions. > Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:281 > +static void adjustRectAccoringToMargin(GtkStyleContext* context, GtkStateFlags state, IntRect& rect) According. Fix also Changelogs Also perhaps adjustScrollbarRectToMargin?
Carlos Garcia Campos
Comment 5 2015-03-19 03:06:50 PDT
(In reply to comment #4) > Comment on attachment 249028 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249028&action=review > > r+ with a nit Thanks for the review. > I guess we haven't detected it in the bots because they don't have 3.16. > It's unfortunate to have to depend on dogfeeding to detect this kind of > regressions. > > > Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:281 > > +static void adjustRectAccoringToMargin(GtkStyleContext* context, GtkStateFlags state, IntRect& rect) > > According. Fix also Changelogs Oops. > Also perhaps adjustScrollbarRectToMargin? The method is more generic than that, it's used for scrollbars, but has nothing to do with scrollbars.
Carlos Garcia Campos
Comment 6 2015-03-19 03:25:34 PDT
Committed r181744: <http://trac.webkit.org/changeset/181744>
Note You need to log in before you can comment on or make changes to this bug.