Bug 140789

Summary: Simple line layout: Reset LineState when starting a new line.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Description zalan 2015-01-22 14:38:54 PST
To be more explicit about what data we need to transfer from the previous line.
Comment 1 zalan 2015-01-22 15:15:02 PST
Created attachment 245170 [details]
Patch
Comment 2 Antti Koivisto 2015-01-22 15:19:07 PST
Comment on attachment 245170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245170&action=review

> Source/WebCore/rendering/SimpleLineLayout.cpp:362
> +static void initializeNewLine(LineState& lineState, const RenderBlockFlow& flow, const FlowContents& flowContents, unsigned lineStartRunIndex)

You could return the new line instead of mutating the argument.
Comment 3 zalan 2015-01-22 15:42:41 PST
Committed r178964: <http://trac.webkit.org/changeset/178964>