Bug 140780

Summary: [Win] No plugin content on some sites.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, andersca, bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description peavo 2015-01-22 13:25:38 PST 
This seems to be caused by ScriptController::createScriptInstanceForWidget() always returning null.
Comment 1 peavo 2015-01-22 13:52:55 PST 
Created attachment 245159 [details]
Patch
Comment 2 Brent Fulgham 2015-01-22 15:10:37 PST 
This may be fallout from our recent refactoring to move Plugins out of WebCore and into the WebKit library.

I've currently got the Plugin tests skipped while I work through the whole set of failures. I will take a look at this soon, but maybe you will get to it sooner! :-)
Comment 3 WebKit Commit Bot 2015-01-22 16:18:32 PST 
Comment on attachment 245159 [details]
Patch

Clearing flags on attachment: 245159

Committed r178968: <http://trac.webkit.org/changeset/178968>
Comment 4 WebKit Commit Bot 2015-01-22 16:18:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 peavo 2015-01-22 23:34:44 PST 
(In reply to comment #2)
> This may be fallout from our recent refactoring to move Plugins out of
> WebCore and into the WebKit library.
>  
> I've currently got the Plugin tests skipped while I work through the whole
> set of failures. I will take a look at this soon, but maybe you will get to
> it sooner! :-)

Thanks for reviewing! It's great that you're looking into the tests, I just noticed this during everyday browsing :)