Bug 140780

Summary: [Win] No plugin content on some sites.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, andersca, bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

peavo
Reported 2015-01-22 13:25:38 PST
This seems to be caused by ScriptController::createScriptInstanceForWidget() always returning null.
Attachments
Patch (3.55 KB, patch)
2015-01-22 13:52 PST, peavo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2015-01-22 13:52:55 PST
Created attachment 245159 [details] Patch
Brent Fulgham
Comment 2 2015-01-22 15:10:37 PST
This may be fallout from our recent refactoring to move Plugins out of WebCore and into the WebKit library. I've currently got the Plugin tests skipped while I work through the whole set of failures. I will take a look at this soon, but maybe you will get to it sooner! :-)
WebKit Commit Bot
Comment 3 2015-01-22 16:18:32 PST
Comment on attachment 245159 [details] Patch Clearing flags on attachment: 245159 Committed r178968: <http://trac.webkit.org/changeset/178968>
WebKit Commit Bot
Comment 4 2015-01-22 16:18:36 PST
All reviewed patches have been landed. Closing bug.
peavo
Comment 5 2015-01-22 23:34:44 PST
(In reply to comment #2) > This may be fallout from our recent refactoring to move Plugins out of > WebCore and into the WebKit library. > > I've currently got the Plugin tests skipped while I work through the whole > set of failures. I will take a look at this soon, but maybe you will get to > it sooner! :-) Thanks for reviewing! It's great that you're looking into the tests, I just noticed this during everyday browsing :)
Note You need to log in before you can comment on or make changes to this bug.