Bug 140773

Summary: [Win] Expose missing editing features through WebView interface
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: HTML EditingAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch dino: review+

Description Brent Fulgham 2015-01-22 10:23:30 PST
Several layout tests fail because the Windows port is not exposing necessary editing support features.
Comment 1 Radar WebKit Bug Importer 2015-01-22 10:23:57 PST
<rdar://problem/19565421>
Comment 2 Brent Fulgham 2015-01-22 15:25:10 PST
Created attachment 245172 [details]
Patch
Comment 3 WebKit Commit Bot 2015-01-22 15:28:07 PST
Attachment 245172 [details] did not pass style-queue:


ERROR: Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/DumpRenderTree/win/EditingDelegate.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dean Jackson 2015-01-22 15:32:56 PST
Comment on attachment 245172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245172&action=review

> Source/WebKit/win/DOMCoreClasses.cpp:2
> + * Copyright (C) 2006, 2007, 2009, 2014 Apple Inc.  All rights reserved.

Check your wall calendar.

> Tools/DumpRenderTree/win/EditingDelegate.cpp:175
> +    static const char* insertactionstring[] = {

insertActionString maybe?

> Tools/DumpRenderTree/win/EditingDelegate.cpp:212
> +    static const char* affinitystring[] = {

Ditto
Comment 5 Brent Fulgham 2015-01-22 15:37:40 PST
(In reply to comment #4)
> Comment on attachment 245172 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245172&action=review
> 
> > Source/WebKit/win/DOMCoreClasses.cpp:2
> > + * Copyright (C) 2006, 2007, 2009, 2014 Apple Inc.  All rights reserved.
> 
> Check your wall calendar.
> 

Doh!

> > Tools/DumpRenderTree/win/EditingDelegate.cpp:175
> > +    static const char* insertactionstring[] = {
> 
> insertActionString maybe?

Sure!

> > Tools/DumpRenderTree/win/EditingDelegate.cpp:212
> > +    static const char* affinitystring[] = {

OK!
> Ditto
Comment 6 Brent Fulgham 2015-01-22 15:46:34 PST
Committed r178965: <http://trac.webkit.org/changeset/178965>