Bug 140742

Summary:

[iOS] Many compositing tests fail in DumpRenderTree due to contentsOpaque difference

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

iOS 8.1

See Also:

https://bugs.webkit.org/show_bug.cgi?id=140697

Attachments:

Description	Flags
Patch	none

Description Daniel Bates 2015-01-21 14:27:09 PST

Many compositing tests fail in DumpRenderTree due to contentsOpaque difference because the main frame's RenderView layer is always transparent in iOS WebKit1.

Comment 1 Daniel Bates 2015-01-21 14:31:21 PST

Created attachment 245092 [details]
Patch

Comment 2 Simon Fraser (smfr) 2015-01-21 14:41:23 PST

Comment on attachment 245092 [details]
Patch

Why don't we just not dump contentsOpaque for this layer.

Comment 3 Daniel Bates 2015-01-21 14:59:18 PST

(In reply to comment #2)
> Comment on attachment 245092 [details]
> Patch
> 
> Why don't we just not dump contentsOpaque for this layer.

Simon and I talked about this on IRC today (01/21). We felt there is value in dumping the contentsOpaque for the main frame's RenderView layer for tiled drawing scrolling tests (e.g. tests under LayoutTests/platform/mac-wk2/tiled-drawing/scrolling).

Comment 4 Daniel Bates 2015-01-21 15:42:09 PST

Comment on attachment 245092 [details]
Patch

Clearing flags on attachment: 245092

Committed r178868: <http://trac.webkit.org/changeset/178868>

Comment 5 Daniel Bates 2015-01-21 15:42:12 PST

All reviewed patches have been landed.  Closing bug.