Bug 140735

Summary: [TexMap] Avoid unnecessary TransformationMatrix copies in GraphicsLayerTransform
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+

Description Zan Dobersek 2015-01-21 12:00:37 PST 
[TexMap] Avoid unnecessary TransformationMatrix copies in GraphicsLayerTransform
Comment 1 Zan Dobersek 2015-01-21 12:10:53 PST 
Created attachment 245075 [details]
Patch
Comment 2 Chris Dumez 2015-01-27 20:41:22 PST 
Comment on attachment 245075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245075&action=review

r=me % nits.

> Source/WebCore/platform/graphics/GraphicsLayerTransform.h:39
> +    const TransformationMatrix& combined();

Why isn't this method const?

> Source/WebCore/platform/graphics/GraphicsLayerTransform.h:40
> +    const TransformationMatrix& combinedForChildren();

Ditto.
Comment 3 Zan Dobersek 2015-02-01 02:04:12 PST 
Comment on attachment 245075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245075&action=review

>> Source/WebCore/platform/graphics/GraphicsLayerTransform.h:40
>> +    const TransformationMatrix& combinedForChildren();
> 
> Ditto.

This calls combineTransformsForChildren(), which modifies m_childrenDirty and m_combinedForChildren.

I prefer combinedForChildren() and combineTransformsForChildren() to be const and have m_childrenDirty and m_combinedForChildren changed to mutable.
Comment 4 Zan Dobersek 2015-02-01 03:34:48 PST 
Landed in r179462.
http://trac.webkit.org/changeset/179462