Bug 140735

Summary: [TexMap] Avoid unnecessary TransformationMatrix copies in GraphicsLayerTransform
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+

Zan Dobersek
Reported 2015-01-21 12:00:37 PST
[TexMap] Avoid unnecessary TransformationMatrix copies in GraphicsLayerTransform
Attachments
Patch (3.26 KB, patch)
2015-01-21 12:10 PST, Zan Dobersek 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2015-01-21 12:10:53 PST
Created attachment 245075 [details] Patch
Chris Dumez
Comment 2 2015-01-27 20:41:22 PST
Comment on attachment 245075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245075&action=review r=me % nits. > Source/WebCore/platform/graphics/GraphicsLayerTransform.h:39 > + const TransformationMatrix& combined(); Why isn't this method const? > Source/WebCore/platform/graphics/GraphicsLayerTransform.h:40 > + const TransformationMatrix& combinedForChildren(); Ditto.
Zan Dobersek
Comment 3 2015-02-01 02:04:12 PST
Comment on attachment 245075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245075&action=review >> Source/WebCore/platform/graphics/GraphicsLayerTransform.h:40 >> + const TransformationMatrix& combinedForChildren(); > > Ditto. This calls combineTransformsForChildren(), which modifies m_childrenDirty and m_combinedForChildren. I prefer combinedForChildren() and combineTransformsForChildren() to be const and have m_childrenDirty and m_combinedForChildren changed to mutable.
Zan Dobersek
Comment 4 2015-02-01 03:34:48 PST
Landed in r179462. http://trac.webkit.org/changeset/179462
Note You need to log in before you can comment on or make changes to this bug.