Bug 140727

Summary: Web Inspector: Don't allow the BasicBlockAnnotator to highlight a section if it's only a closing brace
Product: WebKit Reporter: Saam Barati <saam>
Component: Web InspectorAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch none

Saam Barati
Reported 2015-01-21 09:02:04 PST
There are times when a textual basic block will only consist of blank space, this can happen in the following situation: if (foo) { bar(); return; // Or: throw, break, continue. } // This closing brace will be highlighted, because the code after the return statement is unreachable. This is a common enough case that the BasicBlockAnnotator should special case it.
Attachments
the patch (3.17 KB, patch)
2015-01-21 13:57 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-01-21 09:02:25 PST
<rdar://problem/19548864>
Saam Barati
Comment 2 2015-01-21 13:57:14 PST
Created attachment 245083 [details] the patch
WebKit Commit Bot
Comment 3 2015-01-21 14:51:43 PST
Comment on attachment 245083 [details] the patch Clearing flags on attachment: 245083 Committed r178863: <http://trac.webkit.org/changeset/178863>
WebKit Commit Bot
Comment 4 2015-01-21 14:51:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.