| Summary: | Web Inspector: Don't allow the BasicBlockAnnotator to highlight a section if it's only a closing brace | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
| Component: | Web Inspector | Assignee: | Saam Barati <saam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 245083 [details]
the patch
Comment on attachment 245083 [details] the patch Clearing flags on attachment: 245083 Committed r178863: <http://trac.webkit.org/changeset/178863> All reviewed patches have been landed. Closing bug. |
There are times when a textual basic block will only consist of blank space, this can happen in the following situation: if (foo) { bar(); return; // Or: throw, break, continue. } // This closing brace will be highlighted, because the code after the return statement is unreachable. This is a common enough case that the BasicBlockAnnotator should special case it.