Bug 140704 – [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

The iphoneos SDK is missing the <objc/objc-runtime.h> and <objc/Protocol.h> headers, so they need to be copied from the iphonesimulator SDK to make WebKit build with the external iOS SDK.

This is another step in making the ios-ews queue build.

[David Kilzer (:ddkilzer)]

Created attachment 245035 [details]
Patch v1

[David Kilzer (:ddkilzer)]

*** Bug 140702 has been marked as a duplicate of this bug. ***

[David Kilzer (:ddkilzer)]

Comment on attachment 245035 [details]
Patch v1

Will post a new patch to include fix for Bug 140702.

[David Kilzer (:ddkilzer)]

Created attachment 245056 [details]
Patch v2

[David Kilzer (:ddkilzer)]

*** Bug 140702 has been marked as a duplicate of this bug. ***

[Daniel Bates]

Comment on attachment 245056 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=245056&action=review

> Tools/Scripts/configure-xcode-for-ios-development:85
> +        die "Could not copy $iphonesimulatorSDKPath to $iphoneosSDKPath: $!" if (exitStatus($?) != 0);

I take it you feel it that improves the readability of the code to explicitly check that the exit status is not zero.

[David Kilzer (:ddkilzer)]

(In reply to comment #6)
> Comment on attachment 245056 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245056&action=review
> 
> > Tools/Scripts/configure-xcode-for-ios-development:85
> > +        die "Could not copy $iphonesimulatorSDKPath to $iphoneosSDKPath: $!" if (exitStatus($?) != 0);
> 
> I take it you feel it that improves the readability of the code to
> explicitly check that the exit status is not zero.

I don't feel strongly either way.  Does most code use `!exitStatus($?)` instead of `exitStatus($?) != 0`?

[David Kilzer (:ddkilzer)]

(In reply to comment #7)
> (In reply to comment #6)
> > Comment on attachment 245056 [details]
> > Patch v2
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=245056&action=review
> > 
> > > Tools/Scripts/configure-xcode-for-ios-development:85
> > > +        die "Could not copy $iphonesimulatorSDKPath to $iphoneosSDKPath: $!" if (exitStatus($?) != 0);
> > 
> > I take it you feel it that improves the readability of the code to
> > explicitly check that the exit status is not zero.
> 
> I don't feel strongly either way.  Does most code use `!exitStatus($?)`
> instead of `exitStatus($?) != 0`?

And by `!exitStatus($?)` I meant `exitStatus($?)`.  Will fix before landing.

[David Kilzer (:ddkilzer)]

Committed r178866: <http://trac.webkit.org/changeset/178866>

[David Kilzer (:ddkilzer)]

(In reply to comment #9)
> Committed r178866: <http://trac.webkit.org/changeset/178866>

Note that I added all the headers that were needed to successfully build for the iphoneos SDK at r178719.

[David Kilzer (:ddkilzer)]

(In reply to comment #10)
> (In reply to comment #9)
> > Committed r178866: <http://trac.webkit.org/changeset/178866>
> 
> Note that I added all the headers that were needed to successfully build for
> the iphoneos SDK at r178719.

Follow-up fix for a runtime issue:

Committed r178979: <http://trac.webkit.org/changeset/178979>