Summary: | [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, dbates, ddkilzer, jake.nielsen.webkit | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2015-01-20 16:54:59 PST
Created attachment 245035 [details]
Patch v1
*** Bug 140702 has been marked as a duplicate of this bug. *** Comment on attachment 245035 [details] Patch v1 Will post a new patch to include fix for Bug 140702. Created attachment 245056 [details]
Patch v2
*** Bug 140702 has been marked as a duplicate of this bug. *** Comment on attachment 245056 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=245056&action=review > Tools/Scripts/configure-xcode-for-ios-development:85 > + die "Could not copy $iphonesimulatorSDKPath to $iphoneosSDKPath: $!" if (exitStatus($?) != 0); I take it you feel it that improves the readability of the code to explicitly check that the exit status is not zero. (In reply to comment #6) > Comment on attachment 245056 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245056&action=review > > > Tools/Scripts/configure-xcode-for-ios-development:85 > > + die "Could not copy $iphonesimulatorSDKPath to $iphoneosSDKPath: $!" if (exitStatus($?) != 0); > > I take it you feel it that improves the readability of the code to > explicitly check that the exit status is not zero. I don't feel strongly either way. Does most code use `!exitStatus($?)` instead of `exitStatus($?) != 0`? (In reply to comment #7) > (In reply to comment #6) > > Comment on attachment 245056 [details] > > Patch v2 > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=245056&action=review > > > > > Tools/Scripts/configure-xcode-for-ios-development:85 > > > + die "Could not copy $iphonesimulatorSDKPath to $iphoneosSDKPath: $!" if (exitStatus($?) != 0); > > > > I take it you feel it that improves the readability of the code to > > explicitly check that the exit status is not zero. > > I don't feel strongly either way. Does most code use `!exitStatus($?)` > instead of `exitStatus($?) != 0`? And by `!exitStatus($?)` I meant `exitStatus($?)`. Will fix before landing. Committed r178866: <http://trac.webkit.org/changeset/178866> (In reply to comment #9) > Committed r178866: <http://trac.webkit.org/changeset/178866> Note that I added all the headers that were needed to successfully build for the iphoneos SDK at r178719. (In reply to comment #10) > (In reply to comment #9) > > Committed r178866: <http://trac.webkit.org/changeset/178866> > > Note that I added all the headers that were needed to successfully build for > the iphoneos SDK at r178719. Follow-up fix for a runtime issue: Committed r178979: <http://trac.webkit.org/changeset/178979> |