Bug 140698

Summary: Add and hook up APINavigationClient
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, mitz, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Preliminary Part 2
none
Patch
none
Patch sam: review+

Tim Horton
Reported 2015-01-20 15:23:58 PST
Add and hook up APINavigationClient
Attachments
Patch (67.41 KB, patch)
2015-01-20 15:24 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Preliminary Part 2 (32.80 KB, patch)
2015-01-23 19:12 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (62.43 KB, patch)
2015-01-29 14:52 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (63.25 KB, patch)
2015-01-30 16:50 PST, Tim Horton 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-01-20 15:24:21 PST
Created attachment 245026 [details] Patch
Sam Weinig
Comment 2 2015-01-20 18:06:24 PST
Comment on attachment 245026 [details] Patch Looking good. I think we need to merge the NavigationState conditions and change the NavigationClient names to match the WKNavigationDelegate names before we land this.
Tim Horton
Comment 3 2015-01-23 19:12:54 PST
Created attachment 245271 [details] Preliminary Part 2 Started on Sam's part 2, but haven't finished yet. Here's a WIP.
Tim Horton
Comment 4 2015-01-29 14:52:42 PST
Created attachment 245654 [details] Patch
Tim Horton
Comment 5 2015-01-30 16:25:50 PST
Comment on attachment 245654 [details] Patch Found some things that need fixing.
Tim Horton
Comment 6 2015-01-30 16:50:43 PST
Created attachment 245760 [details] Patch
Tim Horton
Comment 7 2015-01-30 17:29:23 PST
http://trac.webkit.org/changeset/179430
Note You need to log in before you can comment on or make changes to this bug.