Bug 140697

Summary:

Update expected results for compositing tests for WK1

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED INVALID

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

iOS 8.1

See Also:

https://bugs.webkit.org/show_bug.cgi?id=140742

Attachments:

Description	Flags
Patch 1 of 2: Update WebKit1 results	simon.fraser: review+

Daniel Bates

Reported 2015-01-20 15:14:28 PST

We should update the expected results for iOS WebKit1 compositing tests.

Attachments
Patch 1 of 2: Update WebKit1 results (237.30 KB, patch) 2015-01-20 15:16 PST, Daniel Bates	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2015-01-20 15:16:34 PST

Created attachment 245025 [details] Patch 1 of 2: Update WebKit1 results

Daniel Bates

Comment 2 2015-01-21 15:40:46 PST

From talking with Simon Fraser on IRC yesterday (01/21), a more maintainable (*) approach is to have iOS DumpRenderTree lie about the opaqueness of the main frame's RenderView layer. See bug #140742. (*) We consider it a more maintainable approach because it will codify the knowledge that the main frame's RenderView is always transparent in iOS WebKit1 and added compositing tests (or new tests that make use of internal.layerTreeAsText()) will succeed on iOS WebKit1 when they have identical results to the platform-independent -expected.txt files up to the opaqueness of the main frame's RenderView layer. The benefit of codifying such iOS WebKit1-specific logic is that it will not have to be discovered again when a person who is not familiar with iOS WebKit1 quirks looks at expected results or updates expected results that have a layer tree dump.

Note You need to log in before you can comment on or make changes to this bug.