| Summary: | Web Inspector: Expected gutter highlight when selecting console input line, just like output line | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=140580 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 245128 [details]
Patch
Created attachment 245129 [details]
Animated GIF with the patch applied
Comment on attachment 245128 [details] Patch Attachment 245128 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4749603769417728 New failing tests: compositing/geometry/video-opacity-overlay.html Created attachment 245130 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 245128 [details] Patch Clearing flags on attachment: 245128 Committed r178911: <http://trac.webkit.org/changeset/178911> All reviewed patches have been landed. Closing bug. Comment on attachment 245128 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245128&action=review > Source/WebInspectorUI/UserInterface/Views/LogContentView.css:76 > +.console-messages:focus .console-item.selected .console-user-command::after, > .console-messages:focus .console-item.selected .console-message::after { These could both use :matches. But I'll leave that up to you. .console-messages:focus .console-item.selected :matches(.console-user-command, .console-message)::after { ... } Comment on attachment 245128 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245128&action=review >> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:76 >> .console-messages:focus .console-item.selected .console-message::after { > > These could both use :matches. But I'll leave that up to you. > > .console-messages:focus .console-item.selected :matches(.console-user-command, .console-message)::after { ... } I agree. I feel we should use :matches() more. Will do next time. I keep forgetting that I can use some many latest CSS and ECMAScript features. |
Created attachment 245024 [details] [IMAGE] Selection Issue * SUMMARY Expected gutter highlight when selecting console input line, just like output line. See attached images. * STEPS TO REPRODUCE 1. Open inspector 2. js> 1+1 3. Select input and output messages in console => expected same gutter highlight