Bug 140681 – [Win] [SVG-> OTF Converter] Flip the switch on

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Brent Fulgham]

[SVG -> OTF Converter] Flip the switch on (Windows)

[Radar WebKit Bug Importer]

<rdar://problem/19534744>

[Brent Fulgham]

Created attachment 244999 [details]
Patch

[Brent Fulgham]

Created attachment 245000 [details]
Patch

[Brent Fulgham]

Comment on attachment 245000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245000&action=review

> Source/WebCore/svg/SVGToOTFFontConversion.cpp:791
> +    const unsigned featureCount = 5;

MSVC doesn't allow you to use a variable as the argument to an array declaration.

[Brent Fulgham]

It looks like:
(1) We still have differences in SVG after turning this on.
(2) FontCustomPlatformData::fontPlatformData is asserting because m_fontReference is null when running e.g., 'svg/W3C-SVG-1.1/animate-elem-03-t.svg'

Will investigate further.

[Brent Fulgham]

Debugging further, it looks like the buffer generated by convertSVGToOTFFont may be different in some way.

If I pass this buffer through the Windows AddFontMemResourceEx method, it fails.

However, the original code path works.

[Brent Fulgham]

It appears that only font data produced by the ENABLE(SVG_OTF_CONVERTER) code path in CSSFontFaceSource.cpp suffer from this issue (convertSVGToOTFFont).

[Myles C. Maxfield]

(In reply to comment #6)
> Debugging further, it looks like the buffer generated by convertSVGToOTFFont
> may be different in some way.
> 
> If I pass this buffer through the Windows AddFontMemResourceEx method, it
> fails.
> 
> However, the original code path works.

Different than what?

By "original code path," do you mean "with the converter off?"

[Brent Fulgham]

This patch is no longer needed. The feature was turned on in r197145 <http://trac.webkit.org/changeset/197145>.