Bug 140654

Summary:

Resolve the epsilon transitions for each state upfront instead of dynamically

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Benjamin Poulain 2015-01-19 18:09:23 PST

Resolve the epsilon transitions for each state upfront instead of dynamically

Comment 1 Benjamin Poulain 2015-01-19 18:12:06 PST

Created attachment 244947 [details]
Patch

Comment 2 Andreas Kling 2015-01-20 01:31:27 PST

Comment on attachment 244947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244947&action=review

r=me

> Source/WebCore/contentextensions/NFAToDFA.cpp:84
> +        if (nfaNodeClosures[nodeId].size()) {

I softly prefer !isEmpty() over size() here.

Comment 3 Benjamin Poulain 2015-01-20 12:43:27 PST

Committed r178739: <http://trac.webkit.org/changeset/178739>