Summary: | fill property is reported as type SVGColor | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rob Buis <rwlbuis> | ||||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 523.x (Safari 3) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Rob Buis
2007-06-10 19:30:50 PDT
Created attachment 14929 [details]
First attempt
Discussed with Sam, probably worth having this at least for the testcase.
Cheers,
Rob.
Comment on attachment 14929 [details]
First attempt
I assume this is for the experimental branch as this won't apply on ToT (kjs_css.cpp has changed). We should however also land the layout test and the fix (in JSCSSValueCustom.cpp) in ToT as well. r=me
svg/custom/dynamic-viewBox.svg is mentioned in the ChangeLog, but I don't see it in the patch. ChangeLog has the wrong title for the bug. Cant land the layout test in TOT because getPresentationAttribute is not yet in TOT. Created attachment 15572 [details]
patch for trunk, but no good because test won't work
Hi Darin, (In reply to comment #6) > Created an attachment (id=15572) [edit] > patch for trunk, but no good because test won't work I see the dilemma. I guess there are 2 options: 1) fix this when merging experimental branch back into ToT 2) apply the getPresentationAttribute patch to ToT To make the merging lighter, maybe 2 makes that a bit easier. If you agree with that, I can do 2) if you want as I also did the getPresentationAttribute patch. Cheers, Rob. |