Bug 14064

Summary:

fill property is reported as type SVGColor

Product:

WebKit

Reporter:

Rob Buis <rwlbuis>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
First attempt	sam: review+
patch for trunk, but no good because test won't work	none

Rob Buis

Reported 2007-06-10 19:30:50 PDT

When using getPresentationAttribute to get the fill css property, asking for its type gives us SVGColor, it should be SVGPaint.

Attachments
First attempt (20.09 KB, patch) 2007-06-10 23:12 PDT, Rob Buis	sam: review+	Details Formatted Diff Diff
patch for trunk, but no good because test won't work (21.24 KB, patch) 2007-07-18 20:38 PDT, Darin Adler	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2007-06-10 23:12:13 PDT

Created attachment 14929 [details] First attempt Discussed with Sam, probably worth having this at least for the testcase. Cheers, Rob.

Sam Weinig

Comment 2 2007-06-10 23:22:19 PDT

Comment on attachment 14929 [details] First attempt I assume this is for the experimental branch as this won't apply on ToT (kjs_css.cpp has changed). We should however also land the layout test and the fix (in JSCSSValueCustom.cpp) in ToT as well. r=me

Darin Adler

Comment 3 2007-07-18 20:14:45 PDT

svg/custom/dynamic-viewBox.svg is mentioned in the ChangeLog, but I don't see it in the patch.

Darin Adler

Comment 4 2007-07-18 20:15:02 PDT

ChangeLog has the wrong title for the bug.

Darin Adler

Comment 5 2007-07-18 20:37:32 PDT

Cant land the layout test in TOT because getPresentationAttribute is not yet in TOT.

Darin Adler

Comment 6 2007-07-18 20:38:57 PDT

Created attachment 15572 [details] patch for trunk, but no good because test won't work

Rob Buis

Comment 7 2007-07-18 23:35:18 PDT

Hi Darin, (In reply to comment #6) > Created an attachment (id=15572) [edit] > patch for trunk, but no good because test won't work I see the dilemma. I guess there are 2 options: 1) fix this when merging experimental branch back into ToT 2) apply the getPresentationAttribute patch to ToT To make the merging lighter, maybe 2 makes that a bit easier. If you agree with that, I can do 2) if you want as I also did the getPresentationAttribute patch. Cheers, Rob.

Rob Buis

Comment 8 2007-10-03 08:34:14 PDT

This was adapted in rebased fb in r25842 by olliej. For now we close it, have to see later how this makes it into trunk. Cheers, Rob.

Note You need to log in before you can comment on or make changes to this bug.