Summary: | Merge API::ProcessPoolConfiguration and _WKProcessPoolConfiguration | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, ossy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Sam Weinig
2015-01-18 16:55:28 PST
Created attachment 244871 [details]
Patch
Created attachment 244872 [details]
Patch
Comment on attachment 244872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244872&action=review > Source/WebKit2/UIProcess/WebInspectorProxy.cpp:376 > static WebProcessPool* processPool; > if (!processPool) { > - WebProcessPoolConfiguration configuration; > - WebProcessPool::applyPlatformSpecificConfigurationDefaults(configuration); > - > - processPool = (WebProcessPool::create(WTF::move(configuration))).leakRef(); > - processPool->setProcessModel(ProcessModelMultipleSecondaryProcesses); > + auto configuration = API::ProcessPoolConfiguration::createWithLegacyOptions(); > + configuration->setProcessModel(ProcessModelMultipleSecondaryProcesses); > + > + processPool = &(WebProcessPool::create(configuration.get())).leakRef(); > } I think you should initialize this with a lambda: static WebProcessPool& processPool = []{ ... return WebProcessPool::create(configuration.get())).leakRef(); }(); Committed r178685: <http://trac.webkit.org/changeset/178685> (In reply to comment #4) > Committed r178685: <http://trac.webkit.org/changeset/178685> It broke the Apple Mountain Lion and EFL bots: EFL bot - before: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/19081 EFL bot - after: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/19082 Apple Mountain Lion bot - before: https://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/23657 Apple Mountain Lion bot - after: https://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/23658 Could you possibly fix this regression? |