Bug 140601

Summary: Merge API::ProcessPoolConfiguration and _WKProcessPoolConfiguration
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Description Sam Weinig 2015-01-18 16:55:28 PST
Merge API::ProcessPoolConfiguration and _WKProcessPoolConfiguration
Comment 1 Sam Weinig 2015-01-18 18:33:07 PST
Created attachment 244871 [details]
Patch
Comment 2 Sam Weinig 2015-01-18 18:39:10 PST
Created attachment 244872 [details]
Patch
Comment 3 Anders Carlsson 2015-01-19 16:57:01 PST
Comment on attachment 244872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244872&action=review

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:376
>      static WebProcessPool* processPool;
>      if (!processPool) {
> -        WebProcessPoolConfiguration configuration;
> -        WebProcessPool::applyPlatformSpecificConfigurationDefaults(configuration);
> -        
> -        processPool = (WebProcessPool::create(WTF::move(configuration))).leakRef();
> -        processPool->setProcessModel(ProcessModelMultipleSecondaryProcesses);
> +        auto configuration = API::ProcessPoolConfiguration::createWithLegacyOptions();
> +        configuration->setProcessModel(ProcessModelMultipleSecondaryProcesses);
> +
> +        processPool = &(WebProcessPool::create(configuration.get())).leakRef();
>      }

I think you should initialize this with a lambda:

static WebProcessPool& processPool = []{
    ...
    return WebProcessPool::create(configuration.get())).leakRef();
}();
Comment 4 Sam Weinig 2015-01-19 17:35:47 PST
Committed r178685: <http://trac.webkit.org/changeset/178685>
Comment 6 Sam Weinig 2015-01-20 09:51:32 PST
Attempt to fix tests in r178720.