Bug 140567

Summary:

Web Inspector: Do not request Scope Chain lists if section is collapsed (mainly Global Variables)

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-01-16 14:47:47 PST

* SUMMARY
Do not request Scope Chain lists if section is collapsed (mainly Global Variables).

The Global Variables Scope Chain section (and message to populate it) is HUGE. Its sort shows constructors before properties so I normally don't care and I collapse the section. Even if it is collapsed we still update it every pause (so every step, etc). We should avoid this work if we don't need to do it.

Comment 1 Radar WebKit Bug Importer 2015-01-16 14:48:02 PST

<rdar://problem/19504745>

Comment 2 Joseph Pecoraro 2016-08-15 16:02:35 PDT

Created attachment 286108 [details]
[PATCH] Proposed Fix

This should make stepping through code a little faster if users haven't expanded the "Global Variables" section, which defaults to collapsed. On many pages that is a very large message, and it takes non-trivial amount of processing in InjectedScriptSource to build.

Comment 3 WebKit Commit Bot 2016-08-16 10:27:53 PDT

Comment on attachment 286108 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 286108

Committed r204513: <http://trac.webkit.org/changeset/204513>

Comment 4 WebKit Commit Bot 2016-08-16 10:27:57 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Joseph Pecoraro 2017-03-16 14:43:09 PDT

*** Bug 143097 has been marked as a duplicate of this bug. ***