Bug 140551 – When border-radius is present, inset/outset/groove/ridge border color changes.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

We need to call the color adjustment helper when radius is present. (Path vs drawRect codepath)

[zalan]

Created attachment 244783 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 244783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244783&action=review

> Source/WebCore/rendering/RenderObject.h:872
> +    void calculateBorderStyleColor(const EBorderStyle&, const BoxSide&, Color&) const;

It could still be static!

[Build Bot]

Comment on attachment 244783 [details]
Patch

Attachment 244783 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4623629157400576

New failing tests:
fast/borders/wrong-border-color-when-radius-is-present.html

[Build Bot]

Created attachment 244789 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 244783 [details]
Patch

Attachment 244783 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6415907869949952

New failing tests:
fast/borders/wrong-border-color-when-radius-is-present.html

[Build Bot]

Created attachment 244797 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[zalan]

Created attachment 244798 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 244798 [details]
Patch

Clearing flags on attachment: 244798

Committed r178613: <http://trac.webkit.org/changeset/178613>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.