RESOLVED FIXED 140551
When border-radius is present, inset/outset/groove/ridge border color changes. 
https://bugs.webkit.org/show_bug.cgi?id=140551
Summary When border-radius is present, inset/outset/groove/ridge border color changes.
zalan
Reported 2015-01-16 11:40:49 PST
We need to call the color adjustment helper when radius is present. (Path vs drawRect codepath)
Attachments
Patch (8.02 KB, patch)
2015-01-16 12:08 PST, zalan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-mavericks (580.66 KB, application/zip)
2015-01-16 12:47 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (885.81 KB, application/zip)
2015-01-16 13:08 PST, Build Bot 		no flags
Details
Patch (7.82 KB, patch)
2015-01-16 13:15 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2015-01-16 12:08:53 PST
Created attachment 244783 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-01-16 12:12:22 PST
Comment on attachment 244783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244783&action=review > Source/WebCore/rendering/RenderObject.h:872 > + void calculateBorderStyleColor(const EBorderStyle&, const BoxSide&, Color&) const; It could still be static!
Build Bot
Comment 3 2015-01-16 12:47:41 PST
Comment on attachment 244783 [details] Patch Attachment 244783 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4623629157400576 New failing tests: fast/borders/wrong-border-color-when-radius-is-present.html
Build Bot
Comment 4 2015-01-16 12:47:44 PST
Created attachment 244789 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 5 2015-01-16 13:08:37 PST
Comment on attachment 244783 [details] Patch Attachment 244783 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6415907869949952 New failing tests: fast/borders/wrong-border-color-when-radius-is-present.html
Build Bot
Comment 6 2015-01-16 13:08:48 PST
Created attachment 244797 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
zalan
Comment 7 2015-01-16 13:15:28 PST
Created attachment 244798 [details] Patch
WebKit Commit Bot
Comment 8 2015-01-16 16:35:48 PST
Comment on attachment 244798 [details] Patch Clearing flags on attachment: 244798 Committed r178613: <http://trac.webkit.org/changeset/178613>
WebKit Commit Bot
Comment 9 2015-01-16 16:35:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.