Bug 140551 - When border-radius is present, inset/outset/groove/ridge border color changes.
Summary: When border-radius is present, inset/outset/groove/ridge border color changes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-16 11:40 PST by zalan
Modified: 2015-01-16 16:35 PST (History)
7 users (show)

See Also:

Attachments
Patch (8.02 KB, patch)
2015-01-16 12:08 PST, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mavericks (580.66 KB, application/zip)
2015-01-16 12:47 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (885.81 KB, application/zip)
2015-01-16 13:08 PST, Build Bot 		no flags Details
Patch (7.82 KB, patch)
2015-01-16 13:15 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-01-16 11:40:49 PST 
We need to call the color adjustment helper when radius is present. (Path vs drawRect codepath)
Comment 1 zalan 2015-01-16 12:08:53 PST 
Created attachment 244783 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-01-16 12:12:22 PST 
Comment on attachment 244783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244783&action=review

> Source/WebCore/rendering/RenderObject.h:872
> +    void calculateBorderStyleColor(const EBorderStyle&, const BoxSide&, Color&) const;

It could still be static!
Comment 3 Build Bot 2015-01-16 12:47:41 PST 
Comment on attachment 244783 [details]
Patch

Attachment 244783 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4623629157400576

New failing tests:
fast/borders/wrong-border-color-when-radius-is-present.html
Comment 4 Build Bot 2015-01-16 12:47:44 PST 
Created attachment 244789 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-01-16 13:08:37 PST 
Comment on attachment 244783 [details]
Patch

Attachment 244783 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6415907869949952

New failing tests:
fast/borders/wrong-border-color-when-radius-is-present.html
Comment 6 Build Bot 2015-01-16 13:08:48 PST 
Created attachment 244797 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 7 zalan 2015-01-16 13:15:28 PST 
Created attachment 244798 [details]
Patch
Comment 8 WebKit Commit Bot 2015-01-16 16:35:48 PST 
Comment on attachment 244798 [details]
Patch

Clearing flags on attachment: 244798

Committed r178613: <http://trac.webkit.org/changeset/178613>
Comment 9 WebKit Commit Bot 2015-01-16 16:35:52 PST 
All reviewed patches have been landed.  Closing bug.