Bug 140529

Summary: [Mac][EME] Crash in CDMSessionMediaSourceAVFObjC::layerDidReceiveError() - NSError not KVO compliant for key NSUnderlyingError.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+, darin: commit-queue-
Patch for landing none

Jer Noble
Reported 2015-01-15 16:44:40 PST
[Mac][EME] Crash in CDMSessionMediaSourceAVFObjC::layerDidReceiveError() - NSError not KVO compliant for key NSUnderlyingError.
Attachments
Patch (3.11 KB, patch)
2015-01-15 16:46 PST, Jer Noble 		darin: review+
darin: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (1.79 KB, patch)
2015-01-26 09:26 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2015-01-15 16:46:14 PST
Created attachment 244726 [details] Patch
Darin Adler
Comment 2 2015-01-21 07:59:08 PST
Comment on attachment 244726 [details] Patch This has an extra change log entry. How are we regression-testing this fix?
Jer Noble
Comment 3 2015-01-26 09:24:41 PST
(In reply to comment #2) > Comment on attachment 244726 [details] > Patch > > This has an extra change log entry. Whoops, will fix. > How are we regression-testing this fix? We have no idea when or why AVFoundation is firing this type of error (with a code of AVErrorUnknown). Ironically, once we correct this piece and start returning the underlying error, the clients of WebKit's EME API can start reporting what underlying error they're seeing. And we may be able to write a regression or manual test at that point.
Jer Noble
Comment 4 2015-01-26 09:26:48 PST
Created attachment 245354 [details] Patch for landing
Jer Noble
Comment 5 2015-02-03 12:21:21 PST
<rdar://problem/19491197>
WebKit Commit Bot
Comment 6 2015-02-03 13:06:39 PST
Comment on attachment 245354 [details] Patch for landing Clearing flags on attachment: 245354 Committed r179563: <http://trac.webkit.org/changeset/179563>
Note You need to log in before you can comment on or make changes to this bug.