Summary: | [WK2] Add support for fully editable WKWebView | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||
Component: | WebKit2 | Assignee: | Enrica Casucci <enrica> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | OS X 10.10 | ||||||
Attachments: |
|
Description
Enrica Casucci
2015-01-15 15:09:17 PST
Created attachment 244718 [details]
Patch
Comment on attachment 244718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244718&action=review What's up with the WKView.mm changes? > Source/WebKit2/UIProcess/WebPageProxy.cpp:1403 > + m_process->send(Messages::WebPage::SetEditable(editable), m_pageID); I think you can bail if m_process->isValid() is false. > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:85 > +@property (nonatomic, setter=_setEditable:) BOOL _editable; getter should be _isEditable here. Property should still be _editable. > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:931 > + // If the WKWebView is made editable and the selection is empty, set it to something. I'd just say "page" instead of WKWebView here. Thanks for the review. I'll address your comments before landing.
>
> What's up with the WKView.mm changes?
>
I noticed that some of the methods listed in the comment had been implemented.
Committed revision 178536. |