Bug 140515 – [WK2] Add support for fully editable WKWebView

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Enrica Casucci]

This tracks the work required to support in WebKit2 the mode where the WKWebView is fully editable.

[Enrica Casucci]

Created attachment 244718 [details]
Patch

[Anders Carlsson]

Comment on attachment 244718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244718&action=review

What's up with the WKView.mm changes?

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1403
> +    m_process->send(Messages::WebPage::SetEditable(editable), m_pageID);

I think you can bail if m_process->isValid() is false.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:85
> +@property (nonatomic, setter=_setEditable:) BOOL _editable;

getter should be _isEditable here. Property should still be _editable.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:931
> +        // If the WKWebView is made editable and the selection is empty, set it to something.

I'd just say "page" instead of WKWebView here.

[Enrica Casucci]

Thanks for the review. I'll address your comments before landing.
> 
> What's up with the WKView.mm changes?
> 
I noticed that some of the methods listed in the comment had been implemented.

[Enrica Casucci]

Committed revision 178536.