This tracks the work required to support in WebKit2 the mode where the WKWebView is fully editable.
Created attachment 244718 [details]
Comment on attachment 244718 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=244718&action=review
What's up with the WKView.mm changes?
> + m_process->send(Messages::WebPage::SetEditable(editable), m_pageID);
I think you can bail if m_process->isValid() is false.
> +@property (nonatomic, setter=_setEditable:) BOOL _editable;
getter should be _isEditable here. Property should still be _editable.
> + // If the WKWebView is made editable and the selection is empty, set it to something.
I'd just say "page" instead of WKWebView here.
Thanks for the review. I'll address your comments before landing.
> What's up with the WKView.mm changes?
I noticed that some of the methods listed in the comment had been implemented.
Committed revision 178536.