Bug 140425

Summary: [Win] Layout Test fast/css/crash-on-custom-cursor-when-loading.html is failing
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Layout and RenderingAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2015-01-13 20:27:41 PST
The following layout test is failing on Windows.

fast/css/crash-on-custom-cursor-when-loading.html

Probable cause:

Windows is refusing to create a DIB for the 'empty' icon during the initial load phase. This is returning a null value, which is then used in later API calls that assert that the arguments are non-null.

Solution is:
1. If the DIB cannot be created by the operating system based on the icon description, return a nullptr.
2. If the 'createSharedCursor' call returns nullptr, fall back to the default icon case so that we have something that can be used during early layout until the load finishes.
Comment 1 Brent Fulgham 2015-01-13 20:30:07 PST
Created attachment 244574 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-14 10:25:44 PST
Comment on attachment 244574 [details]
Patch

Clearing flags on attachment: 244574

Committed r178424: <http://trac.webkit.org/changeset/178424>
Comment 3 WebKit Commit Bot 2015-01-14 10:25:47 PST
All reviewed patches have been landed.  Closing bug.