Should disable immediate actions for iTunes

• Component: WebKit API
• Status: RESOLVED FIXED

[Beth Dakin]

Should disable immediate actions for iTunes

rdar://problem/19274499

[Beth Dakin]

Created attachment 244541 [details]
Patch

[Beth Dakin]

Created attachment 244543 [details]
Patch

[Tim Horton]

Comment on attachment 244543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244543&action=review

> Source/WebKit/mac/WebView/WebImmediateActionController.mm:228
> +    if (customClientAnimationController == [NSNull null] || applicationIsITunes()) {

I think we should avoid doing all of this work and just not install the GR if we're in iTunes.

[Beth Dakin]

(In reply to comment #3)
> Comment on attachment 244543 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244543&action=review
> 
> > Source/WebKit/mac/WebView/WebImmediateActionController.mm:228
> > +    if (customClientAnimationController == [NSNull null] || applicationIsITunes()) {
> 
> I think we should avoid doing all of this work and just not install the GR
> if we're in iTunes.

Tim and I talked about this in person. We went back and forth a few times, but ultimately decided to keep it as-is to match the SPI.

http://trac.webkit.org/changeset/178378