Bug 140405

Summary: Should disable immediate actions for iTunes
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Beth Dakin
Reported 2015-01-13 13:47:49 PST
Should disable immediate actions for iTunes rdar://problem/19274499
Attachments
Patch (2.02 KB, patch)
2015-01-13 13:50 PST, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Patch (2.96 KB, patch)
2015-01-13 14:00 PST, Beth Dakin 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2015-01-13 13:50:18 PST
Created attachment 244541 [details] Patch
Beth Dakin
Comment 2 2015-01-13 14:00:33 PST
Created attachment 244543 [details] Patch
Tim Horton
Comment 3 2015-01-13 14:09:53 PST
Comment on attachment 244543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244543&action=review > Source/WebKit/mac/WebView/WebImmediateActionController.mm:228 > + if (customClientAnimationController == [NSNull null] || applicationIsITunes()) { I think we should avoid doing all of this work and just not install the GR if we're in iTunes.
Beth Dakin
Comment 4 2015-01-13 14:34:30 PST
(In reply to comment #3) > Comment on attachment 244543 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244543&action=review > > > Source/WebKit/mac/WebView/WebImmediateActionController.mm:228 > > + if (customClientAnimationController == [NSNull null] || applicationIsITunes()) { > > I think we should avoid doing all of this work and just not install the GR > if we're in iTunes. Tim and I talked about this in person. We went back and forth a few times, but ultimately decided to keep it as-is to match the SPI. http://trac.webkit.org/changeset/178378
Note You need to log in before you can comment on or make changes to this bug.