| Summary: | Add generic Capture class for cross-thread lambda captures | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||||||||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||||||||||||
| Status: | RESOLVED WONTFIX | ||||||||||||||||||||
| Severity: | Normal | CC: | andersca, buildbot, commit-queue, darin, kling, koivisto, rniwa | ||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Zan Dobersek
2015-01-13 01:40:38 PST
Created attachment 244504 [details]
Patch
Attachment 244504 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:227: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 244504 [details] Patch Attachment 244504 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6240355376693248 New failing tests: http/tests/xmlhttprequest/workers/methods-async.html http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html http/tests/xmlhttprequest/workers/methods.html Created attachment 244506 [details]
Archive of layout-test-results from ews104 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 245064 [details]
WIP
Attachment 245064 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:227: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 245064 [details] WIP Attachment 245064 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6340507974238208 New failing tests: http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html Created attachment 245067 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 245064 [details] WIP Attachment 245064 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5556820458340352 New failing tests: http/tests/xmlhttprequest/workers/methods-async.html http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html http/tests/xmlhttprequest/workers/methods.html Created attachment 245076 [details]
Archive of layout-test-results from ews100 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 245295 [details]
WIP
Attachment 245295 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:227: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 246099 [details]
WIP
Attachment 246099 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:227: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 246099 [details] WIP Attachment 246099 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6618914465251328 New failing tests: http/tests/xmlhttprequest/workers/methods-async.html http/tests/xmlhttprequest/workers/methods.html Created attachment 246102 [details]
Archive of layout-test-results from ews101 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
C++14 now enables more efficient initialization of captured values. |