Bug 140382

Summary:

Perf dashboard always assigns the result of A/B testing with build request 1

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

WebKit Misc.

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	none

Description Ryosuke Niwa 2015-01-12 21:52:45 PST

There's a subtle bug in report-processor.php that results in all A/B testing results being associated with the build request with id=1.

Comment 1 Ryosuke Niwa 2015-01-12 22:00:29 PST

Created attachment 244495 [details]
Fixes the bug

Comment 2 Ryosuke Niwa 2015-01-23 16:22:28 PST

Thanks for the review!

Comment 3 Ryosuke Niwa 2015-01-23 16:24:27 PST

Comment on attachment 244495 [details]
Fixes the bug

Clearing flags on attachment: 244495

Committed r179037: <http://trac.webkit.org/changeset/179037>

Comment 4 Ryosuke Niwa 2015-01-23 16:24:31 PST

All reviewed patches have been landed.  Closing bug.