Bug 140370

Summary: Make delegates conform to formal delegate protocols
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Anders Carlsson
Reported 2015-01-12 12:55:25 PST
Make delegates conform to formal delegate protocols
Attachments
Patch (28.28 KB, patch)
2015-01-12 12:57 PST, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-01-12 12:57:31 PST
Created attachment 244459 [details] Patch
mitz
Comment 2 2015-01-12 13:05:17 PST
Comment on attachment 244459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244459&action=review > Tools/DumpRenderTree/mac/TestRunnerMac.mm:254 > + return [(id)[[mainFrame webView] UIDelegate] numberOfPendingGeolocationPermissionRequests]; You should cast to UIDelegate * here. > Tools/DumpRenderTree/mac/TestRunnerMac.mm:438 > + [(id)[[mainFrame webView] UIDelegate] didSetMockGeolocationPermission]; And here.
Anders Carlsson
Comment 3 2015-01-12 13:07:57 PST
Committed r178293: <http://trac.webkit.org/changeset/178293>
Note You need to log in before you can comment on or make changes to this bug.