Bug 140370

Summary:

Make delegates conform to formal delegate protocols

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+

Description Anders Carlsson 2015-01-12 12:55:25 PST

Make delegates conform to formal delegate protocols

Comment 1 Anders Carlsson 2015-01-12 12:57:31 PST

Created attachment 244459 [details]
Patch

Comment 2 mitz 2015-01-12 13:05:17 PST

Comment on attachment 244459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244459&action=review

> Tools/DumpRenderTree/mac/TestRunnerMac.mm:254
> +    return [(id)[[mainFrame webView] UIDelegate] numberOfPendingGeolocationPermissionRequests];

You should cast to UIDelegate * here.

> Tools/DumpRenderTree/mac/TestRunnerMac.mm:438
> +    [(id)[[mainFrame webView] UIDelegate] didSetMockGeolocationPermission];

And here.

Comment 3 Anders Carlsson 2015-01-12 13:07:57 PST

Committed r178293: <http://trac.webkit.org/changeset/178293>