Bug 140362

Summary: build.webkit.org/dashboard should filter out commits to other branches
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: bshafiei, darin, dbates, thorton, timothy
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix thorton: review+

Alexey Proskuryakov
Reported 2015-01-12 09:41:46 PST
It is misleading to have the dashboard say "XXX revisions behind" when these changes are on a different branch, or when they are on a tag. We can use branch information from trac to do this. Even better, it may be possible to somehow get informed about ignored patches (e.g. patches that only touch ChangeLog, or patches for other files that are in a blacklist for the given platform).
Attachments
proposed fix (14.40 KB, patch)
2015-02-22 22:08 PST, Alexey Proskuryakov 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-01-14 22:36:22 PST
rdar://problem/15971525
Alexey Proskuryakov
Comment 2 2015-02-22 22:08:05 PST
Created attachment 247097 [details] proposed fix
Tim Horton
Comment 3 2015-02-22 22:13:08 PST
Comment on attachment 247097 [details] proposed fix YAY!
Alexey Proskuryakov
Comment 4 2015-02-23 09:43:09 PST
Committed <http://trac.webkit.org/r180504>.
Jason Marcell
Comment 5 2016-01-22 17:33:26 PST
Comment on attachment 247097 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=247097&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:244 > + fromDate and toDate end up having the same value. Was this intentional?
Alexey Proskuryakov
Comment 6 2016-01-22 23:04:15 PST
I think so, it's supposed to download commits for that one day.
Note You need to log in before you can comment on or make changes to this bug.