Bug 140362

Summary:

build.webkit.org/dashboard should filter out commits to other branches

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bshafiei, darin, dbates, thorton, timothy

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	thorton: review+

Description Alexey Proskuryakov 2015-01-12 09:41:46 PST

It is misleading to have the dashboard say "XXX revisions behind" when these changes are on a different branch, or when they are on a tag.

We can use branch information from trac to do this. Even better, it may be possible to somehow get informed about ignored patches (e.g. patches that only touch ChangeLog, or patches for other files that are in a blacklist for the given platform).

Comment 1 Alexey Proskuryakov 2015-01-14 22:36:22 PST

rdar://problem/15971525

Comment 2 Alexey Proskuryakov 2015-02-22 22:08:05 PST

Created attachment 247097 [details]
proposed fix

Comment 3 Tim Horton 2015-02-22 22:13:08 PST

Comment on attachment 247097 [details]
proposed fix

YAY!

Comment 4 Alexey Proskuryakov 2015-02-23 09:43:09 PST

Committed <http://trac.webkit.org/r180504>.

Comment 5 Jason Marcell 2016-01-22 17:33:26 PST

Comment on attachment 247097 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=247097&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:244
> +

fromDate and toDate end up having the same value. Was this intentional?

Comment 6 Alexey Proskuryakov 2016-01-22 23:04:15 PST

I think so, it's supposed to download commits for that one day.