Bug 140355

Summary: AX: [ATK] Mark accessibility/table-with-footer-section-above-body.html as a suitable test for EFL and GTK
Product: WebKit Reporter: Andrzej Badowski <a.badowski>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, k.czech, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch
none
proposed patch 2
cfleizach: review+
proposed patch 3
commit-queue: commit-queue-
proposed patch 4 none

Andrzej Badowski
Reported 2015-01-12 04:43:05 PST
The test shows the text contents of a AccessibilityTableCell object using tableCell.childAtIndex(0).stringValue. In the case of ATK childAtIndex(0) returns a non-empty object, but it is not the ATK_OBJECT, so the stringValue produces an empty string. To avoid this, the cell text content is obtained by direct reading of stringValue of TableCell.
Attachments
proposed patch (5.17 KB, patch)
2015-01-12 05:13 PST, Andrzej Badowski
no flags
proposed patch 2 (4.79 KB, patch)
2015-01-12 05:22 PST, Andrzej Badowski
cfleizach: review+
proposed patch 3 (4.88 KB, patch)
2015-01-13 01:16 PST, Andrzej Badowski
commit-queue: commit-queue-
proposed patch 4 (4.75 KB, patch)
2015-01-13 03:48 PST, Andrzej Badowski
no flags
Radar WebKit Bug Importer
Comment 1 2015-01-12 04:43:19 PST
Andrzej Badowski
Comment 2 2015-01-12 05:13:24 PST
Created attachment 244442 [details] proposed patch
Andrzej Badowski
Comment 3 2015-01-12 05:22:55 PST
Created attachment 244443 [details] proposed patch 2
chris fleizach
Comment 4 2015-01-12 11:41:54 PST
Comment on attachment 244443 [details] proposed patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=244443&action=review > LayoutTests/ChangeLog:8 > + The test shows the text contents of a AccessibilityTableCell object using tableCell.childAtIndex(0).stringValue. of "an" AccessibilityTableCell
Andrzej Badowski
Comment 5 2015-01-13 01:16:24 PST
Created attachment 244501 [details] proposed patch 3
WebKit Commit Bot
Comment 6 2015-01-13 03:31:37 PST
Comment on attachment 244501 [details] proposed patch 3 Rejecting attachment 244501 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 244501, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5692178365939712
Andrzej Badowski
Comment 7 2015-01-13 03:48:44 PST
Created attachment 244505 [details] proposed patch 4
WebKit Commit Bot
Comment 8 2015-01-13 05:14:14 PST
Comment on attachment 244505 [details] proposed patch 4 Clearing flags on attachment: 244505 Committed r178362: <http://trac.webkit.org/changeset/178362>
WebKit Commit Bot
Comment 9 2015-01-13 05:14:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.