Bug 140355

Summary: AX: [ATK] Mark accessibility/table-with-footer-section-above-body.html as a suitable test for EFL and GTK
Product: WebKit Reporter: Andrzej Badowski <a.badowski>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, k.czech, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch
none
proposed patch 2
cfleizach: review+
proposed patch 3
commit-queue: commit-queue-
proposed patch 4 none

Description Andrzej Badowski 2015-01-12 04:43:05 PST 
The test shows the text contents of a AccessibilityTableCell object using tableCell.childAtIndex(0).stringValue. In the case of ATK childAtIndex(0) returns a non-empty object, but it is not the ATK_OBJECT, so the stringValue produces an empty string. To avoid this, the cell text content is obtained by direct reading of stringValue of TableCell.
Comment 1 Radar WebKit Bug Importer 2015-01-12 04:43:19 PST 
<rdar://problem/19442319>
Comment 2 Andrzej Badowski 2015-01-12 05:13:24 PST 
Created attachment 244442 [details]
proposed patch
Comment 3 Andrzej Badowski 2015-01-12 05:22:55 PST 
Created attachment 244443 [details]
proposed patch 2
Comment 4 chris fleizach 2015-01-12 11:41:54 PST 
Comment on attachment 244443 [details]
proposed patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=244443&action=review

> LayoutTests/ChangeLog:8
> +        The test shows the text contents of a AccessibilityTableCell object using tableCell.childAtIndex(0).stringValue.

of "an" AccessibilityTableCell
Comment 5 Andrzej Badowski 2015-01-13 01:16:24 PST 
Created attachment 244501 [details]
proposed patch 3
Comment 6 WebKit Commit Bot 2015-01-13 03:31:37 PST 
Comment on attachment 244501 [details]
proposed patch 3

Rejecting attachment 244501 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 244501, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5692178365939712
Comment 7 Andrzej Badowski 2015-01-13 03:48:44 PST 
Created attachment 244505 [details]
proposed patch 4
Comment 8 WebKit Commit Bot 2015-01-13 05:14:14 PST 
Comment on attachment 244505 [details]
proposed patch 4

Clearing flags on attachment: 244505

Committed r178362: <http://trac.webkit.org/changeset/178362>
Comment 9 WebKit Commit Bot 2015-01-13 05:14:19 PST 
All reviewed patches have been landed.  Closing bug.