Summary: | Move 'kerning' / 'paint-order' / 'stroke-dasharray' SVG CSS properties to the new StyleBuilder | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, darin, kling, koivisto, ossy, sam | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 137910 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Chris Dumez
2015-01-09 16:50:58 PST
Created attachment 244394 [details]
Patch
Created attachment 244395 [details]
Patch
Created attachment 244398 [details]
Patch
Comment on attachment 244398 [details] Patch Clearing flags on attachment: 244398 Committed r178237: <http://trac.webkit.org/changeset/178237> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > Comment on attachment 244398 [details] > Patch > > Clearing flags on attachment: 244398 > > Committed r178237: <http://trac.webkit.org/changeset/178237> It made 500+ tests fail on the Apple Yosemite bots. (In reply to comment #6) > (In reply to comment #4) > > Comment on attachment 244398 [details] > > Patch > > > > Clearing flags on attachment: 244398 > > > > Committed r178237: <http://trac.webkit.org/changeset/178237> > > It made 500+ tests fail on the Apple Yosemite bots. Thanks, I am checking now. (In reply to comment #6) > (In reply to comment #4) > > Comment on attachment 244398 [details] > > Patch > > > > Clearing flags on attachment: 244398 > > > > Committed r178237: <http://trac.webkit.org/changeset/178237> > > It made 500+ tests fail on the Apple Yosemite bots. Hmm.. I don't think it is me. If you look at the history (https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20%28Tests%29?numbuilds=100), you'll see the 500 failures started earlier (apparently it is flakey because the build before my patch was temporarily green). You're right, I haven't checked the longer history. Sorry for blaming your patch. |