Bug 140327

Summary: Move 'kerning' / 'paint-order' / 'stroke-dasharray' SVG CSS properties to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, kling, koivisto, ossy, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2015-01-09 16:50:58 PST
Move 'kerning' / 'paint-order' / 'stroke-dasharray' SVG CSS properties to the new StyleBuilder.
Attachments
Patch (11.07 KB, patch)
2015-01-09 17:18 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.08 KB, patch)
2015-01-09 17:20 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.97 KB, patch)
2015-01-09 18:42 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-01-09 17:18:16 PST
Created attachment 244394 [details] Patch
Chris Dumez
Comment 2 2015-01-09 17:20:31 PST
Created attachment 244395 [details] Patch
Chris Dumez
Comment 3 2015-01-09 18:42:54 PST
Created attachment 244398 [details] Patch
WebKit Commit Bot
Comment 4 2015-01-10 00:49:38 PST
Comment on attachment 244398 [details] Patch Clearing flags on attachment: 244398 Committed r178237: <http://trac.webkit.org/changeset/178237>
WebKit Commit Bot
Comment 5 2015-01-10 00:49:42 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2015-01-10 01:52:09 PST
(In reply to comment #4) > Comment on attachment 244398 [details] > Patch > > Clearing flags on attachment: 244398 > > Committed r178237: <http://trac.webkit.org/changeset/178237> It made 500+ tests fail on the Apple Yosemite bots.
Chris Dumez
Comment 7 2015-01-10 01:58:49 PST
(In reply to comment #6) > (In reply to comment #4) > > Comment on attachment 244398 [details] > > Patch > > > > Clearing flags on attachment: 244398 > > > > Committed r178237: <http://trac.webkit.org/changeset/178237> > > It made 500+ tests fail on the Apple Yosemite bots. Thanks, I am checking now.
Chris Dumez
Comment 8 2015-01-10 02:00:59 PST
(In reply to comment #6) > (In reply to comment #4) > > Comment on attachment 244398 [details] > > Patch > > > > Clearing flags on attachment: 244398 > > > > Committed r178237: <http://trac.webkit.org/changeset/178237> > > It made 500+ tests fail on the Apple Yosemite bots. Hmm.. I don't think it is me. If you look at the history (https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20%28Tests%29?numbuilds=100), you'll see the 500 failures started earlier (apparently it is flakey because the build before my patch was temporarily green).
Csaba Osztrogonác
Comment 9 2015-01-12 02:14:47 PST
You're right, I haven't checked the longer history. Sorry for blaming your patch.
Note You need to log in before you can comment on or make changes to this bug.