Bug 140327

Summary: Move 'kerning' / 'paint-order' / 'stroke-dasharray' SVG CSS properties to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, kling, koivisto, ossy, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2015-01-09 16:50:58 PST
Move 'kerning' / 'paint-order' / 'stroke-dasharray' SVG CSS properties to the new StyleBuilder.
Comment 1 Chris Dumez 2015-01-09 17:18:16 PST
Created attachment 244394 [details]
Patch
Comment 2 Chris Dumez 2015-01-09 17:20:31 PST
Created attachment 244395 [details]
Patch
Comment 3 Chris Dumez 2015-01-09 18:42:54 PST
Created attachment 244398 [details]
Patch
Comment 4 WebKit Commit Bot 2015-01-10 00:49:38 PST
Comment on attachment 244398 [details]
Patch

Clearing flags on attachment: 244398

Committed r178237: <http://trac.webkit.org/changeset/178237>
Comment 5 WebKit Commit Bot 2015-01-10 00:49:42 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogonác 2015-01-10 01:52:09 PST
(In reply to comment #4)
> Comment on attachment 244398 [details]
> Patch
> 
> Clearing flags on attachment: 244398
> 
> Committed r178237: <http://trac.webkit.org/changeset/178237>

It made 500+ tests fail on the Apple Yosemite bots.
Comment 7 Chris Dumez 2015-01-10 01:58:49 PST
(In reply to comment #6)
> (In reply to comment #4)
> > Comment on attachment 244398 [details]
> > Patch
> > 
> > Clearing flags on attachment: 244398
> > 
> > Committed r178237: <http://trac.webkit.org/changeset/178237>
> 
> It made 500+ tests fail on the Apple Yosemite bots.

Thanks, I am checking now.
Comment 8 Chris Dumez 2015-01-10 02:00:59 PST
(In reply to comment #6)
> (In reply to comment #4)
> > Comment on attachment 244398 [details]
> > Patch
> > 
> > Clearing flags on attachment: 244398
> > 
> > Committed r178237: <http://trac.webkit.org/changeset/178237>
> 
> It made 500+ tests fail on the Apple Yosemite bots.

Hmm.. I don't think it is me. If you look at the history (https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20%28Tests%29?numbuilds=100), you'll see the 500 failures started earlier (apparently it is flakey because the build before my patch was temporarily green).
Comment 9 Csaba Osztrogonác 2015-01-12 02:14:47 PST
You're right, I haven't checked the longer history. Sorry for blaming your patch.