Summary: | Web Inspector: REGRESSION: Navigation sidebar can show blank next to the Console view | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Timothy Hatcher
2015-01-09 08:10:23 PST
Created attachment 244343 [details]
Patch
Comment on attachment 244343 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244343&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:975 > + this._ignoreNavigationSidebarPanelCollapsedEvent = true; > + this.navigationSidebar.collapsed = true; > + delete this._ignoreNavigationSidebarPanelCollapsedEvent; I wonder if we should just set _ignore to false instead of deleting it. That would mean that later, the property lookup doesn't need to walk the prototype chain, and should just find the property immediately. > Source/WebInspectorUI/UserInterface/Base/Main.js:979 > + // Restore the sidebar if was forced collapsed earlier because of no selectedSidebarPanel. Grammar: "if was forced" => "if it was forced" Comment on attachment 244343 [details] Patch Clearing flags on attachment: 244343 Committed r178184: <http://trac.webkit.org/changeset/178184> All reviewed patches have been landed. Closing bug. |