Bug 140291 – Web Inspector: REGRESSION: Navigation sidebar can show blank next to the Console view

• Component: Web Inspector
• Status: RESOLVED FIXED

[Timothy Hatcher]

After http://trac.webkit.org/changeset/178155 I have sometimes seen the navigation sidebar appear on launch when restoring to the Console view. Not sure what the steps are, but I have a patch to avoid it.

[Radar WebKit Bug Importer]

<rdar://problem/19426210>

[Timothy Hatcher]

Created attachment 244343 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 244343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244343&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:975
> +        this._ignoreNavigationSidebarPanelCollapsedEvent = true;
> +        this.navigationSidebar.collapsed = true;
> +        delete this._ignoreNavigationSidebarPanelCollapsedEvent;

I wonder if we should just set _ignore to false instead of deleting it. That would mean that later, the property lookup doesn't need to walk the prototype chain, and should just find the property immediately.

> Source/WebInspectorUI/UserInterface/Base/Main.js:979
> +    // Restore the sidebar if was forced collapsed earlier because of no selectedSidebarPanel.

Grammar: "if was forced" => "if it was forced"

[WebKit Commit Bot]

Comment on attachment 244343 [details]
Patch

Clearing flags on attachment: 244343

Committed r178184: <http://trac.webkit.org/changeset/178184>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.