Bug 140282

Summary:

defaultPlaybackRate not respected when set before sourec is loaded

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

140366

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none
Patch for landing	none

Jer Noble

Reported 2015-01-08 19:58:32 PST

defaultPlaybackRate not respected when set before sourec is loaded

Attachments
Patch (26.59 KB, patch) 2015-01-08 22:04 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (27.08 KB, patch) 2015-01-09 12:11 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (24.45 KB, patch) 2015-01-12 13:48 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (27.83 KB, patch) 2015-01-12 14:12 PST, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2015-01-08 22:04:29 PST

Created attachment 244328 [details] Patch

Eric Carlson

Comment 2 2015-01-09 10:57:57 PST

Comment on attachment 244328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244328&action=review > Source/WebCore/html/HTMLMediaElement.cpp:265 > + , m_playbackRate(1) This name makes it even less clear what this is used for now that there are 3 rate ivars. I think something like "m_requestedRate" would be better. > LayoutTests/ChangeLog:3 > + defaultPlaybackRate not respected when set before sourec is loaded Typo: sourec -> source

Jer Noble

Comment 3 2015-01-09 11:15:36 PST

(In reply to comment #2) > Comment on attachment 244328 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244328&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:265 > > + , m_playbackRate(1) > > This name makes it even less clear what this is used for now that there are > 3 rate ivars. I think something like "m_requestedRate" would be better. I originally changed it to m_requestedPlaybackRate, but changed it back. I'll re-make that change. > > LayoutTests/ChangeLog:3 > > + defaultPlaybackRate not respected when set before sourec is loaded > > Typo: sourec -> source Whoops!

Jer Noble

Comment 4 2015-01-09 12:11:56 PST

Created attachment 244363 [details] Patch for landing

WebKit Commit Bot

Comment 5 2015-01-12 10:15:08 PST

Comment on attachment 244363 [details] Patch for landing Clearing flags on attachment: 244363 Committed r178281: <http://trac.webkit.org/changeset/178281>

Csaba Osztrogonác

Comment 6 2015-01-12 10:57:50 PST

(In reply to comment #5) > Comment on attachment 244363 [details] > Patch for landing > > Clearing flags on attachment: 244363 > > Committed r178281: <http://trac.webkit.org/changeset/178281> It broke many tests everywhere: - Apple Yosemite WK2: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20%28Tests%29/builds/1895 - Apple Yosemite WK1: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20%28Tests%29/builds/1904 - GTK: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/5336

Alexey Proskuryakov

Comment 7 2015-01-12 11:57:21 PST

Yes, I'm going to roll out.

Jer Noble

Comment 8 2015-01-12 13:48:55 PST

Created attachment 244464 [details] Patch for landing Replaced two more instances of 'effectivePlaybackRate()' with 'requsetedPlaybackRate()'.

Jer Noble

Comment 9 2015-01-12 14:12:56 PST

Created attachment 244466 [details] Patch for landing Replaced two more instances of 'effectivePlaybackRate()' with 'requsetedPlaybackRate()'.

WebKit Commit Bot

Comment 10 2015-01-13 12:01:44 PST

Comment on attachment 244466 [details] Patch for landing Clearing flags on attachment: 244466 Committed r178367: <http://trac.webkit.org/changeset/178367>

Note You need to log in before you can comment on or make changes to this bug.