Summary: | defaultPlaybackRate not respected when set before sourec is loaded | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, ossy | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 140366 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Jer Noble
2015-01-08 19:58:32 PST
Created attachment 244328 [details]
Patch
Comment on attachment 244328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244328&action=review > Source/WebCore/html/HTMLMediaElement.cpp:265 > + , m_playbackRate(1) This name makes it even less clear what this is used for now that there are 3 rate ivars. I think something like "m_requestedRate" would be better. > LayoutTests/ChangeLog:3 > + defaultPlaybackRate not respected when set before sourec is loaded Typo: sourec -> source (In reply to comment #2) > Comment on attachment 244328 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244328&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:265 > > + , m_playbackRate(1) > > This name makes it even less clear what this is used for now that there are > 3 rate ivars. I think something like "m_requestedRate" would be better. I originally changed it to m_requestedPlaybackRate, but changed it back. I'll re-make that change. > > LayoutTests/ChangeLog:3 > > + defaultPlaybackRate not respected when set before sourec is loaded > > Typo: sourec -> source Whoops! Created attachment 244363 [details]
Patch for landing
Comment on attachment 244363 [details] Patch for landing Clearing flags on attachment: 244363 Committed r178281: <http://trac.webkit.org/changeset/178281> (In reply to comment #5) > Comment on attachment 244363 [details] > Patch for landing > > Clearing flags on attachment: 244363 > > Committed r178281: <http://trac.webkit.org/changeset/178281> It broke many tests everywhere: - Apple Yosemite WK2: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20%28Tests%29/builds/1895 - Apple Yosemite WK1: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20%28Tests%29/builds/1904 - GTK: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/5336 Yes, I'm going to roll out. Created attachment 244464 [details]
Patch for landing
Replaced two more instances of 'effectivePlaybackRate()' with 'requsetedPlaybackRate()'.
Created attachment 244466 [details]
Patch for landing
Replaced two more instances of 'effectivePlaybackRate()' with 'requsetedPlaybackRate()'.
Comment on attachment 244466 [details] Patch for landing Clearing flags on attachment: 244466 Committed r178367: <http://trac.webkit.org/changeset/178367> |