Bug 140272

Summary:

Make WKNavigation bridged to API::Navigation

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

140294

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	mitz: review+

Sam Weinig

Reported 2015-01-08 15:21:05 PST

Make WKNavigation bridged to API::Navigation

Attachments
Patch (26.51 KB, patch) 2015-01-08 15:23 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (26.53 KB, patch) 2015-01-09 12:07 PST, Sam Weinig	mitz: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2015-01-08 15:23:58 PST

Created attachment 244301 [details] Patch

WebKit Commit Bot

Comment 2 2015-01-08 15:26:44 PST

Attachment 244301 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.mm:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 3 2015-01-08 15:48:31 PST

Committed r178141: <http://trac.webkit.org/changeset/178141>

Alexey Proskuryakov

Comment 4 2015-01-09 09:44:20 PST

This broke multiple API tests, I'm going to roll out. https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20%28Tests%29/builds/1325/steps/run-api-tests/logs/stdio

WebKit Commit Bot

Comment 5 2015-01-09 09:46:32 PST

Re-opened since this is blocked by bug 140294

Sam Weinig

Comment 6 2015-01-09 12:07:41 PST

Created attachment 244361 [details] Patch