Bug 140272

Summary: Make WKNavigation bridged to API::Navigation
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 140294    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Description Sam Weinig 2015-01-08 15:21:05 PST
Make WKNavigation bridged to API::Navigation
Comment 1 Sam Weinig 2015-01-08 15:23:58 PST
Created attachment 244301 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-08 15:26:44 PST
Attachment 244301 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.mm:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2015-01-08 15:48:31 PST
Committed r178141: <http://trac.webkit.org/changeset/178141>
Comment 4 Alexey Proskuryakov 2015-01-09 09:44:20 PST
This broke multiple API tests, I'm going to roll out.

https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20%28Tests%29/builds/1325/steps/run-api-tests/logs/stdio
Comment 5 WebKit Commit Bot 2015-01-09 09:46:32 PST
Re-opened since this is blocked by bug 140294
Comment 6 Sam Weinig 2015-01-09 12:07:41 PST
Created attachment 244361 [details]
Patch
Comment 7 Sam Weinig 2015-01-09 12:08:16 PST
New patch fixes the tests by fixing the overreleasing of WKNavigations.
Comment 8 Sam Weinig 2015-01-09 12:10:28 PST
Committed r178185: <http://trac.webkit.org/changeset/178185>