Summary: | Make WKNavigation bridged to API::Navigation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 140294 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Sam Weinig
2015-01-08 15:21:05 PST
Created attachment 244301 [details]
Patch
Attachment 244301 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.mm:29: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r178141: <http://trac.webkit.org/changeset/178141> This broke multiple API tests, I'm going to roll out. https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20%28Tests%29/builds/1325/steps/run-api-tests/logs/stdio Re-opened since this is blocked by bug 140294 Created attachment 244361 [details]
Patch
New patch fixes the tests by fixing the overreleasing of WKNavigations. Committed r178185: <http://trac.webkit.org/changeset/178185> |