| Summary: | Unfriend StyleResolver and StyleBuilderCustom | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2015-01-08 08:13:34 PST
Created attachment 244268 [details]
Patch
Comment on attachment 244268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244268&action=review That turned out really nice. > Source/WebCore/css/StyleResolver.h:165 > + Settings* documentSettings() { return m_document.settings(); } Really annoying that settings can be null. We need to get Kling on the case to help us figure out how to do this. Maybe we can move Settings from Page to MainFrame? > Source/WebCore/css/StyleResolver.h:-322 > - Settings* documentSettings() { return m_document.settings(); } Might need to remove a blank line here to avoid a double black line. Comment on attachment 244268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244268&action=review >> Source/WebCore/css/StyleResolver.h:-322 >> - Settings* documentSettings() { return m_document.settings(); } > > Might need to remove a blank line here to avoid a double black line. I only see 1 blank line. Comment on attachment 244268 [details] Patch Clearing flags on attachment: 244268 Committed r178123: <http://trac.webkit.org/changeset/178123> All reviewed patches have been landed. Closing bug. |