Bug 140237

Summary: Web Inspector: Do not create rulesMap entries for rules without identifiers
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-01-07 19:32:01 PST
* SUMMARY We are accidentally creating rulesMap entries for rules without identifiers. This was causing a bogus entry in the rulesMap which could cause problems later on. We started with a null mapKey, which accidentally turns into a string with: > mapKey += ":" + occurrence;
Attachments
[PATCH] Proposed Fix (1.64 KB, patch)
2015-01-07 19:47 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-01-07 19:32:25 PST
<rdar://problem/19408185>
Joseph Pecoraro
Comment 2 2015-01-07 19:47:25 PST
Created attachment 244236 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2015-01-07 20:37:19 PST
Comment on attachment 244236 [details] [PATCH] Proposed Fix Clearing flags on attachment: 244236 Committed r178096: <http://trac.webkit.org/changeset/178096>
WebKit Commit Bot
Comment 4 2015-01-07 20:37:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.