Bug 140229

Summary:

Web Inspector: ObjC Generate types from the GenericTypes domain

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

burg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-01-07 16:52:01 PST

* SUMMARY
ObjC Types should generate types from the GenericTypes domain, as they are expected elsewhere.

For example, Page domain expects GenericTypes.SearchMatch:

    @protocol RWIProtocolPageDomainHandler <NSObject>
    - (void)searchInResourceWithErrorCallback:(void(^)(NSString *error))errorCallback successCallback:(void(^)(NSArray/*<RWIProtocolGenericTypesSearchMatch>*/ *result))successCallback...;
    @end

Comment 1 Radar WebKit Bug Importer 2015-01-07 16:52:17 PST

<rdar://problem/19406637>

Comment 2 Joseph Pecoraro 2015-01-07 16:53:43 PST

Created attachment 244223 [details]
[PATCH] Proposed Fix

Comment 3 WebKit Commit Bot 2015-01-07 16:55:38 PST

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

Comment 4 WebKit Commit Bot 2015-01-07 17:59:32 PST

Comment on attachment 244223 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 244223

Committed r178075: <http://trac.webkit.org/changeset/178075>

Comment 5 WebKit Commit Bot 2015-01-07 17:59:35 PST

All reviewed patches have been landed.  Closing bug.