Bug 14019

Summary: SVG focus ring support has minor display bugs
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: emacemac7, zimmermann
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on: 10849, 14015, 25532    
Bug Blocks:    
Attachments:
Description Flags
focus ring tests showing some remaining bugs none

Eric Seidel (no email)
Reported 2007-06-06 12:42:43 PDT
SVG focus ring support has minor display bugs Now that SVG has focus ring support (thanks to bug 10849), we need to go back and clean up some of the display bugs such support exposes. Some examples of bugs: - focus rings for paths do not conform to path shape - focus rings for paths are 1px larger than necessary (due to antialiasing fuzz in the absoluteBounds method) - focus rings do not respect clip when sizing themselves (see <image> example) - text focus rings do not respect transform= attributes correctly - image focus rings do not respect transform= attributes correctly
Attachments
focus ring tests showing some remaining bugs (1.46 KB, image/svg+xml)
2007-06-06 12:44 PDT, Eric Seidel (no email) 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-06-06 12:44:57 PDT
Created attachment 14887 [details] focus ring tests showing some remaining bugs This test case has already been landed as svg/custom/focus-ring.svg
Eric Seidel (no email)
Comment 2 2007-10-12 02:23:09 PDT
Focus ring painting will actually improve once we fix bug 14015, because at least RenderSVGImage depends on a proper computeAbsoluteRepaintRect implementation (which we don't currently have).
Eric Seidel (no email)
Comment 3 2009-05-03 15:37:52 PDT
I've fixed text focus rings locally. Will be uploading that patch soon.
Nikolas Zimmermann
Comment 4 2010-07-08 23:53:50 PDT
Fixed in trunk.
Note You need to log in before you can comment on or make changes to this bug.